public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] usb: kbd: add transfer error interrupt handling
Date: Fri, 10 Apr 2015 23:47:37 -0600	[thread overview]
Message-ID: <5528B579.4020806@wwwdotorg.org> (raw)
In-Reply-To: <1428721621-11422-1-git-send-email-swarren@wwwdotorg.org>

On 04/10/2015 09:07 PM, Stephen Warren wrote:
> If the USB transfer fails or otherwise returns no data, don't process the
> (non-existent) reponse data and generate keypresses from it. Doing so
> makes each successful transaction appear to be a new keypress, which
> results in ridiculously fast key repeat rates.
> 
> FIXME: This breaks USB keyboard on at least NVIDIA Tegra Seaboard, hence
> why this is an RFC.

I've tracked down the issue here, and it looks like I can replace this
patch with a patch to DWC2. So, ignore this patch and I'll post the DWC2
patch soon; it's working now but I need to add a timeout to a loop and
do some more testing.

> I wonder if submit_int_msg() is expected to keep executing until a
> successful transfer is made? That would likely explain why the existing
> lack of error handling has no negative effect on non-DWC2 platforms.

  reply	other threads:[~2015-04-11  5:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-11  3:07 [U-Boot] [RFC PATCH] usb: kbd: add transfer error interrupt handling Stephen Warren
2015-04-11  5:47 ` Stephen Warren [this message]
2015-04-11 16:44   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5528B579.4020806@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox