public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/4] mtd: nand: mxs: Calculate ECC strength dynamically
Date: Tue, 14 Apr 2015 08:11:41 +0200	[thread overview]
Message-ID: <552CAF9D.6090201@denx.de> (raw)
In-Reply-To: <1428956274-18362-1-git-send-email-joerg.krause@embedded.rocks>

Hello J?rg,

Am 13.04.2015 22:17, schrieb J?rg Krause:
> This series of patches are based on the patch of Peng Fan:
> https://patchwork.ozlabs.org/patch/422756/
>
> Patch 1 is the originally patch from Peng Fan, Patch 2 and 3 add minor changes
> to 1 and patch 4 adds the ECC strength calculation to tools/mxsboot to be
> aligned with the changes made in patch 1 to 3.
>
> Instead of hard-coding every possible oob size / ECC strength combination
> calculate the ECC strength dynamically to be aligned with the Linux Kernel
> MTD NAND driver. Also adds the calculation to tools/mxsboot to be aligned
> with the U-Boot MTD NAND driver.
>
> Obviously, we have some code redundancy here in mxs_nand.c and mxsboot.c.
>
> J?rg Krause (3):
>    mtd: nand: mxs: Replace magic number for bits per ECC level with macro
>    mtd: nand: mxs: Add comment for calculating ECC strength
>    tools: mxsboot: Calculate ECC strength dynamically
>
> Peng Fan (1):
>    mtd:mxs:nand calculate ecc strength dynamically
>
>   drivers/mtd/nand/mxs_nand.c | 36 +++++++++++++++---------------------
>   tools/mxsboot.c             | 39 ++++++++++++++++++++++++---------------
>   2 files changed, 39 insertions(+), 36 deletions(-)

Tried this patches on the aristainetos2 board. UBI on the nand works
nice with this patches, so:

Acked-by: Heiko Schocher <hs@denx.de>

This patchset replaces my patch:

Patchwork [U-Boot] mxs_nand: Fix ECC strength for NAND flash with OOB size of 256
http://patchwork.ozlabs.org/patch/460462/

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      parent reply	other threads:[~2015-04-14  6:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 20:17 [U-Boot] [PATCH v2 0/4] mtd: nand: mxs: Calculate ECC strength dynamically Jörg Krause
2015-04-13 20:17 ` [U-Boot] [PATCH v2 1/4] mtd:mxs:nand calculate ecc " Jörg Krause
2015-04-13 20:17 ` [U-Boot] [PATCH v2 2/4] mtd: nand: mxs: Replace magic number for bits per ECC level with macro Jörg Krause
2015-04-13 20:17 ` [U-Boot] [PATCH v2 3/4] mtd: nand: mxs: Add comment for calculating ECC strength Jörg Krause
2015-04-14  6:12   ` Heiko Schocher
2015-04-14  6:29     ` Jörg Krause
2015-04-14  8:02       ` Heiko Schocher
2015-04-14 15:32         ` Jörg Krause
2015-04-15  5:39           ` Heiko Schocher
2015-04-13 20:17 ` [U-Boot] [PATCH v2 4/4] tools: mxsboot: Calculate ECC strength dynamically Jörg Krause
2015-04-14  6:11 ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552CAF9D.6090201@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox