From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 14 Apr 2015 08:12:53 +0200 Subject: [U-Boot] [PATCH v2 3/4] mtd: nand: mxs: Add comment for calculating ECC strength In-Reply-To: <1428956274-18362-4-git-send-email-joerg.krause@embedded.rocks> References: <1428956274-18362-1-git-send-email-joerg.krause@embedded.rocks> <1428956274-18362-4-git-send-email-joerg.krause@embedded.rocks> Message-ID: <552CAFE5.409@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello J?rg, Am 13.04.2015 22:17, schrieb J?rg Krause: > Signed-off-by: J?rg Krause > --- > drivers/mtd/nand/mxs_nand.c | 7 +++++++ > 1 file changed, 7 insertions(+) nitpick only ... > diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c > index 912fed8..76e47ab 100644 > --- a/drivers/mtd/nand/mxs_nand.c > +++ b/drivers/mtd/nand/mxs_nand.c > @@ -148,6 +148,13 @@ static inline uint32_t mxs_nand_get_ecc_strength(uint32_t page_data_size, > { > int ecc_strength; > > + /* Determine the ECC layout with the formula: wrong comment style ... please fix also in patch 4/4... thanks. bye, Heiko > + * ECC bits per chunk = (total page spare data bits) / > + * (bits per ECC level) / (chunks per page) > + * where: > + * total page spare data bits = > + * (page oob size - meta data size) * (bits per byte) > + */ > ecc_strength = ((page_oob_size - MXS_NAND_METADATA_SIZE) * 8) > / (MXS_NAND_BITS_PER_ECC_LEVEL * > mxs_nand_ecc_chunk_cnt(page_data_size)); > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany