From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 15 Apr 2015 07:39:58 +0200 Subject: [U-Boot] [PATCH v2 3/4] mtd: nand: mxs: Add comment for calculating ECC strength In-Reply-To: <1429025563.16289.8.camel@embedded.rocks> References: <1428956274-18362-1-git-send-email-joerg.krause@embedded.rocks> <1428956274-18362-4-git-send-email-joerg.krause@embedded.rocks> <552CAFE5.409@denx.de> <1428992951.2266.6.camel@embedded.rocks> <552CC97D.3030408@denx.de> <1429025563.16289.8.camel@embedded.rocks> Message-ID: <552DF9AE.9040204@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello J?rg, Am 14.04.2015 17:32, schrieb J?rg Krause: > Hello Heiko, > > On Di, 2015-04-14 at 10:02 +0200, Heiko Schocher wrote: >> Hello J?rg, >> >> Am 14.04.2015 08:29, schrieb J?rg Krause: >>> Hello Heiko, >>> >>> On Di, 2015-04-14 at 08:12 +0200, Heiko Schocher wrote: >>>> Hello J?rg, >>>> >>>> Am 13.04.2015 22:17, schrieb J?rg Krause: >>>>> Signed-off-by: J?rg Krause >>>>> --- >>>>> drivers/mtd/nand/mxs_nand.c | 7 +++++++ >>>>> 1 file changed, 7 insertions(+) >>>> >>>> nitpick only ... >>> >>> I'm unsure what this comment means translated to German. Something >>> like small changes only? >> >> Yes, something like "pingelig" > > Okay, now I understand the translation but not the meaning. Do you > mean that this patch should be squashed into patch 1 for example? > >> >>>>> diff --git a/drivers/mtd/nand/mxs_nand.c >>>>> b/drivers/mtd/nand/mxs_nand.c >>>>> index 912fed8..76e47ab 100644 >>>>> --- a/drivers/mtd/nand/mxs_nand.c >>>>> +++ b/drivers/mtd/nand/mxs_nand.c >>>>> @@ -148,6 +148,13 @@ static inline uint32_t >>>>> mxs_nand_get_ecc_strength(uint32_t page_data_size, >>>>> { >>>>> int ecc_strength; >>>>> >>>>> + /* Determine the ECC layout with the formula: >>>> >>>> wrong comment style ... please fix also in patch 4/4... thanks. >>> >>> Checkpatch did not complain and I did not know there is a coding >>> style >>> for comments. Should it be: >>> /* >>> * Determine the ECC layout... >> >> Yes. >> >> See: linux:/Documentation/CodingStyle search for >> "The preferred style for long (multi-line) comments is" > > Thanks! So shall I send a v3 for this patch or will this be fixed by a > maintainer? Please sent a v3 ... and add Scott Wood to Cc as he is the nand maintainer, thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany