public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <Peng.Fan@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [dm/next PATCH v1] dm: qspi fix claim bus and release bus
Date: Wed, 15 Apr 2015 17:50:03 +0800	[thread overview]
Message-ID: <552E344B.3000000@freescale.com> (raw)
In-Reply-To: <1428988763-32733-1-git-send-email-Peng.Fan@freescale.com>

Add missed people.

On 4/14/2015 1:19 PM, Peng Fan wrote:
> For fsl_qspi_claim_bus and fsl_qspi_release_bus, the input parameter
> "struct udevice *dev" represents device: "qspi[x]: qspi@[address] {...}".
> Since "dev" already represents the qspi controller, use its parent to
> get platdata and get 'priv' is wrong.
>
> After applying this patch, qspi flashes can be correctly probed.
>
> CC: Simon Glass <sjg@chromium.org>
> CC: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
> CC: Haikun Wang <Haikun.Wang@freescale.com>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> ---
>
> Hi,
>
> This patch is based on dm/next branch.
>
> Regards,
> Peng.
>
>   drivers/spi/fsl_qspi.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
> index 868df5f..04f1801 100644
> --- a/drivers/spi/fsl_qspi.c
> +++ b/drivers/spi/fsl_qspi.c
> @@ -1044,11 +1044,9 @@ static int fsl_qspi_xfer(struct udevice *dev, unsigned int bitlen,
>   static int fsl_qspi_claim_bus(struct udevice *dev)
>   {
>   	struct fsl_qspi_priv *priv;
> -	struct udevice *bus;
> -	struct dm_spi_slave_platdata *slave_plat = dev_get_parent_platdata(dev);
> +	struct dm_spi_slave_platdata *slave_plat = dev_get_platdata(dev);
>   
> -	bus = dev->parent;
> -	priv = dev_get_priv(bus);
> +	priv = dev_get_priv(dev);
>   
>   	priv->cur_amba_base =
>   		priv->amba_base[0] + FSL_QSPI_FLASH_SIZE * slave_plat->cs;
> @@ -1061,10 +1059,8 @@ static int fsl_qspi_claim_bus(struct udevice *dev)
>   static int fsl_qspi_release_bus(struct udevice *dev)
>   {
>   	struct fsl_qspi_priv *priv;
> -	struct udevice *bus;
>   
> -	bus = dev->parent;
> -	priv = dev_get_priv(bus);
> +	priv = dev_get_priv(dev);
>   
>   	qspi_module_disable(priv, 1);
>   

  reply	other threads:[~2015-04-15  9:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  5:19 [U-Boot] [dm/next PATCH v1] dm: qspi fix claim bus and release bus Peng Fan
2015-04-15  9:50 ` Peng Fan [this message]
2015-04-23 15:17   ` Simon Glass
2015-04-26  7:05     ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552E344B.3000000@freescale.com \
    --to=peng.fan@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox