public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video, ipu: make ldb_clock configurable
Date: Wed, 15 Apr 2015 17:16:31 -0700	[thread overview]
Message-ID: <552EFF5F.9040100@boundarydevices.com> (raw)
In-Reply-To: <1428826758-484-1-git-send-email-hs@denx.de>

Hi Heiko,

On 04/12/2015 01:19 AM, Heiko Schocher wrote:
> make the ldb_clock configurable through the new define
> CONFIG_SYS_LDB_CLOCK. This is needed as the ldb clock is not
> always 650000000, for example on the aristainetos2 board,
> where the ldb clock derives from PLL5 clock.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> 
>  drivers/video/ipu_common.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/ipu_common.c b/drivers/video/ipu_common.c
> index 5873531..1a209d4 100644
> --- a/drivers/video/ipu_common.c
> +++ b/drivers/video/ipu_common.c
> @@ -210,9 +210,13 @@ static struct clk ipu_clk = {
>  	.usecount = 0,
>  };
>  
> +#if !defined CONFIG_SYS_LDB_CLOCK

You might want to count the zeros here:

> +#define CONFIG_SYS_LDB_CLOCK 650000000

That big a number will break existing code.

> +#endif
> +
>  static struct clk ldb_clk = {
>  	.name = "ldb_clk",
> -	.rate = 65000000,
> +	.rate = CONFIG_SYS_LDB_CLOCK,
>  	.usecount = 0,
>  };
>  
> 

Tested-by: Eric Nelson <eric.nelson@boundarydevices.com>

      reply	other threads:[~2015-04-16  0:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12  8:19 [U-Boot] [PATCH] video, ipu: make ldb_clock configurable Heiko Schocher
2015-04-16  0:16 ` Eric Nelson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552EFF5F.9040100@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox