[U-Boot] [PATCH 03/10] sunxi: Introduce a hidden ARCH_SUN6I Kconfig bool

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 15-04-15 21:47, Ian Campbell wrote:
> On Wed, 2015-04-15 at 10:45 +0200, Michal Suchanek wrote:
>> It is not obvious which MACH_SUN?I are ARCH_SUN6I derived. So if you
>> can come up with a descriptive name for 'a number of things in common,
>> such as having separate ahb reset registers in the ccm' that's fine
>> otherwise this obfuscates the code, not clarifies.
>
> I don't particularly object to the patch but this occurred to me too. I
> suppose the rule is "first sunxi to look this way".
>
> How about we call groups of similar SoCs a "generation", i.e.
> ARCH_SUNXI_GEN2 is what is called ARCH_SUN6I here, meaning GEN1 would be
> SUN4/5/7I.

I like the GEN idea, but not the numbering as it is a bit too arbitrary
how about: ARCH_SUNXI_GEN_SUN6I or (better I think) just SUNXI_GEN_SUN6I ?

I know that does not solve the fact that MACH_SUN7I is SUNXI_GEN_SUN4I
but we cannot fix that, at least this way it will be explicit.

Regards,

Hans