From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 16 Apr 2015 09:46:27 +0200 Subject: [U-Boot] [PATCH 26/34] imx: ventana: add DT fixup for GW54xx compatibility with older kernels In-Reply-To: <1428522904-8111-27-git-send-email-tharvey@gateworks.com> References: <1428522904-8111-1-git-send-email-tharvey@gateworks.com> <1428522904-8111-27-git-send-email-tharvey@gateworks.com> Message-ID: <552F68D3.9060305@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tim, I have no problem with the whole series, I will start to apply. Just a couple of questions: On 08/04/2015 21:54, Tim Harvey wrote: > Certain older kernels in use by some customers erroneously define a uart3 > for GW54xx with a pinmux that conflicts with NAND. This will remove > that node to avoid such conflicts. > > Signed-off-by: Tim Harvey > --- > board/gateworks/gw_ventana/gw_ventana.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/board/gateworks/gw_ventana/gw_ventana.c b/board/gateworks/gw_ventana/gw_ventana.c > index 068c726..06611b5 100644 > --- a/board/gateworks/gw_ventana/gw_ventana.c > +++ b/board/gateworks/gw_ventana/gw_ventana.c > @@ -1599,6 +1599,17 @@ int ft_board_setup(void *blob, bd_t *bd) > strlen((const char *)info->model) + 1); > > /* > + * disable serial2 node for GW54xx for compatibility with older > + * 3.10.x kernel that improperly had this node enabled in the DT > + */ I understand the issue, but I guess you have a dtb file for your (Freescale) 3.10 kernel and another one for kernel mainline. So why this issue should be fixed here and not in the related DTS file ? > + if (board_type == GW54xx) { > + i = fdt_path_offset(blob, > + "/soc/aips-bus at 02100000/serial at 021ec000"); > + if (i) > + fdt_del_node(blob, i); > + } > + > + /* > * disable wdog1/wdog2 nodes for GW51xx below revC to work around > * errata causing wdog timer to be unreliable. > */ > Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================