public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: Remove unused variable in usb_setup_descriptor()
Date: Mon, 20 Apr 2015 09:27:51 +0200	[thread overview]
Message-ID: <5534AA77.3050406@redhat.com> (raw)
In-Reply-To: <CAPnjgZ0hFwPwhvxx+NZz2KEZF7ti0zYqmu4Wn6zTqq6Dh4B1Zw@mail.gmail.com>

Hi,

On 19-04-15 15:36, Simon Glass wrote:
> Hi Hans,
>
> On 19 April 2015 at 03:33, Hans de Goede <hdegoede@redhat.com> wrote:
>> The compiler did not catch this as it was marked __maybe_unused.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   common/usb.c | 2 --
>>   1 file changed, 2 deletions(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> Thanks for spotting this. Another minor problem is that
> get_descriptor_len() allocates a 512-byte buffer but only 64 bytes is
> needed.

Good one, someone should probably write a patch for this. Consider such
a patch Acked-by: Hans de Goede <hdegoede@redhat.com> .

Whom is going to pick up these fixes and upstream them ?

Regards,

Hans

  reply	other threads:[~2015-04-20  7:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19  9:33 [U-Boot] [PATCH 0/1] usb: Remove unused variable in usb_setup_descriptor() Hans de Goede
2015-04-19  9:33 ` [U-Boot] [PATCH] " Hans de Goede
2015-04-19 13:36   ` Simon Glass
2015-04-20  7:27     ` Hans de Goede [this message]
2015-04-21 10:21       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5534AA77.3050406@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox