From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Date: Mon, 20 Apr 2015 09:27:51 +0200
Subject: [U-Boot] [PATCH] usb: Remove unused variable in
	usb_setup_descriptor()
In-Reply-To: <CAPnjgZ0hFwPwhvxx+NZz2KEZF7ti0zYqmu4Wn6zTqq6Dh4B1Zw@mail.gmail.com>
References: <1429436001-8727-1-git-send-email-hdegoede@redhat.com>	<1429436001-8727-2-git-send-email-hdegoede@redhat.com>
 <CAPnjgZ0hFwPwhvxx+NZz2KEZF7ti0zYqmu4Wn6zTqq6Dh4B1Zw@mail.gmail.com>
Message-ID: <5534AA77.3050406@redhat.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 19-04-15 15:36, Simon Glass wrote:
> Hi Hans,
>
> On 19 April 2015 at 03:33, Hans de Goede <hdegoede@redhat.com> wrote:
>> The compiler did not catch this as it was marked __maybe_unused.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   common/usb.c | 2 --
>>   1 file changed, 2 deletions(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> Thanks for spotting this. Another minor problem is that
> get_descriptor_len() allocates a 512-byte buffer but only 64 bytes is
> needed.

Good one, someone should probably write a patch for this. Consider such
a patch Acked-by: Hans de Goede <hdegoede@redhat.com> .

Whom is going to pick up these fixes and upstream them ?

Regards,

Hans