From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Tue, 7 Jul 2020 20:00:21 +0800 Subject: =?UTF-8?Q?Re=3a_=5bPATCH_v4_6/6=5d_rockchip=3a_make=5ffit=5fatf=3a_?= =?UTF-8?B?YWRkIHNpZ25hdHVyZSBoYW5kbGluZ+OAkOivt+azqOaEj++8jOmCruS7tueUsXNq?= =?UTF-8?B?Z0Bnb29nbGUuY29t5Luj5Y+R44CR?= In-Reply-To: References: <20200619104550.1972307-1-heiko@sntech.de> <20200619104550.1972307-7-heiko@sntech.de> Message-ID: <5535b5c0-e59b-c020-78b4-efd318b65830@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 2020/6/26 ??9:12, Simon Glass wrote: > Hi Heiko, > > On Fri, 19 Jun 2020 at 04:45, Heiko Stuebner wrote: >> From: Heiko Stuebner >> >> If the newly added fit-generator key-options are found, append needed >> signature nodes to all generated image blocks, so that they can get >> signed when mkimage later compiles the .itb from the generated .its. >> >> Signed-off-by: Heiko Stuebner >> --- >> arch/arm/mach-rockchip/make_fit_atf.py | 57 +++++++++++++++++++++++++- >> 1 file changed, 56 insertions(+), 1 deletion(-) > We have to stop the growth of these ad-hoc scripts or U-Boot with > become a tangled mess of vendor-specific scripts. > > I sent a series to convert more of rockchip to use binman. Can you > please take a look at that? > > It deletes the fit_spl_optee.sh script. We need to delete make_fit_atf as well. The fit_spl_optee.sh is much more simple because it use optee.bin directly for u-boot.itb, while make_fit_atf needs to parse bl31.elf and get the start address for different blob. Any suggestion on how this could be implement in binman? Thanks, - Kever > > Regards, > Simon > >