public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH][v2] iMX: Fix compilation error when enabling SECURE_BOOT
@ 2015-04-06  7:35 Gaurav Rana
  2015-04-06 14:28 ` Ulises Cardenas
  2015-04-22 12:52 ` Stefano Babic
  0 siblings, 2 replies; 3+ messages in thread
From: Gaurav Rana @ 2015-04-06  7:35 UTC (permalink / raw)
  To: u-boot

Move the compilation of file fsl_validate.c in MACRO CONFIG_CMD_ESBC_VALIDATE.
This file should be compiled only when the above MACRO is defined

This caused a break in compilation of iMX platforms when compiling for SECURE_BOOT

Signed-off-by: Gaurav Rana <gaurav.rana@freescale.com>
---
Changes in V2:
Corrected the commit message.

 board/freescale/common/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/freescale/common/Makefile b/board/freescale/common/Makefile
index 7181cac..87d0578 100644
--- a/board/freescale/common/Makefile
+++ b/board/freescale/common/Makefile
@@ -74,8 +74,7 @@ obj-$(CONFIG_P5040DS)	+= p_corenet/
 obj-$(CONFIG_LS102XA_NS_ACCESS)	+= ns_access.o
 
 ifdef CONFIG_SECURE_BOOT
-obj-y += fsl_validate.o
-obj-$(CONFIG_CMD_ESBC_VALIDATE) += cmd_esbc_validate.o
+obj-$(CONFIG_CMD_ESBC_VALIDATE) += fsl_validate.o cmd_esbc_validate.o
 endif
 
 endif
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH][v2] iMX: Fix compilation error when enabling SECURE_BOOT
  2015-04-06  7:35 [U-Boot] [PATCH][v2] iMX: Fix compilation error when enabling SECURE_BOOT Gaurav Rana
@ 2015-04-06 14:28 ` Ulises Cardenas
  2015-04-22 12:52 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Ulises Cardenas @ 2015-04-06 14:28 UTC (permalink / raw)
  To: u-boot

Hi Gaurav,
On 4/6/15 2:35 AM, Gaurav Rana wrote:
> Move the compilation of file fsl_validate.c in MACRO CONFIG_CMD_ESBC_VALIDATE.
> This file should be compiled only when the above MACRO is defined
>
> This caused a break in compilation of iMX platforms when compiling for SECURE_BOOT
>
> Signed-off-by: Gaurav Rana <gaurav.rana@freescale.com>
> ---
> Changes in V2:
> Corrected the commit message.
>
>   board/freescale/common/Makefile | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/board/freescale/common/Makefile b/board/freescale/common/Makefile
> index 7181cac..87d0578 100644
> --- a/board/freescale/common/Makefile
> +++ b/board/freescale/common/Makefile
> @@ -74,8 +74,7 @@ obj-$(CONFIG_P5040DS)	+= p_corenet/
>   obj-$(CONFIG_LS102XA_NS_ACCESS)	+= ns_access.o
>   
>   ifdef CONFIG_SECURE_BOOT
> -obj-y += fsl_validate.o
> -obj-$(CONFIG_CMD_ESBC_VALIDATE) += cmd_esbc_validate.o
> +obj-$(CONFIG_CMD_ESBC_VALIDATE) += fsl_validate.o cmd_esbc_validate.o
>   endif
>   
>   endif

This fixes the issue. Tested on iMX6q and iMX6sx.

Regards,
Ulises Cardenas

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH][v2] iMX: Fix compilation error when enabling SECURE_BOOT
  2015-04-06  7:35 [U-Boot] [PATCH][v2] iMX: Fix compilation error when enabling SECURE_BOOT Gaurav Rana
  2015-04-06 14:28 ` Ulises Cardenas
@ 2015-04-22 12:52 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2015-04-22 12:52 UTC (permalink / raw)
  To: u-boot

On 06/04/2015 09:35, Gaurav Rana wrote:
> Move the compilation of file fsl_validate.c in MACRO CONFIG_CMD_ESBC_VALIDATE.
> This file should be compiled only when the above MACRO is defined
> 
> This caused a break in compilation of iMX platforms when compiling for SECURE_BOOT
> 
> Signed-off-by: Gaurav Rana <gaurav.rana@freescale.com>
> ---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-22 12:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-06  7:35 [U-Boot] [PATCH][v2] iMX: Fix compilation error when enabling SECURE_BOOT Gaurav Rana
2015-04-06 14:28 ` Ulises Cardenas
2015-04-22 12:52 ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox