From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Thu, 23 Apr 2015 14:36:35 +0200 Subject: [U-Boot] [PATCH v4 11/16] dm: regulator: add fixed voltage regulator driver In-Reply-To: <5538E62E.4060201@samsung.com> References: <1427229051-20170-1-git-send-email-p.marczak@samsung.com> <1429553273-6453-1-git-send-email-p.marczak@samsung.com> <1429553273-6453-12-git-send-email-p.marczak@samsung.com> <5538E62E.4060201@samsung.com> Message-ID: <5538E753.5000904@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de +CC Simon On 04/23/2015 02:31 PM, Przemyslaw Marczak wrote: > Hello Simon, > > On 04/20/2015 08:07 PM, Przemyslaw Marczak wrote: >> This driver implements regulator operations for fixed Voltage/Current >> value regulators. beside the standard regulator constraints, which are >> put into the uclass platform data, a typical fixed regulator node >> provides >> few additional properties like: >> - gpio >> - gpio-open-drain >> - enable-active-high >> - startup-delay-us >> The only 'gpio' is used by this driver and is kept in structure of type >> 'fixed_regulator_platdata', as a device platform data (dev->platdata). >> >> The driver implements: >> - get_value >> - get_current >> - get_enable >> - set_enable >> >> The regulator calls and commands can be used for fixed-regulator devices, >> and the proper error will be returned for prohibited. >> >> Signed-off-by: Przemyslaw Marczak >> > > I missed the separation (---) here and I see that you add ACK below the > changes. > Could you remove them from the tree? > [...] Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com