public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "spi: add config option to enable the WP pin function on st micron flashes"
Date: Thu, 23 Apr 2015 15:09:45 +0200	[thread overview]
Message-ID: <5538EF19.8070702@denx.de> (raw)
In-Reply-To: <CAD6G_RQ1y0Gg5Wpt9szkqNyndfnv5YeGVMaT_FKYWO9PK+v=sg@mail.gmail.com>

Hello Jagan,

Am 23.04.2015 15:06, schrieb Jagan Teki:
> On 23 April 2015 at 18:28, Heiko Schocher <hs@denx.de> wrote:
>> Hello Jagan,
>>
>> Am 22.04.2015 13:03, schrieb Jagan Teki:
>>>
>>> On 23 December 2014 at 13:45, Jagan Teki <jagannadh.teki@gmail.com> wrote:
>>>>
>>>> Hi Heiko,
>>>>
>>>> On 23 December 2014 at 12:04, Heiko Schocher <hs@denx.de> wrote:
>>>>>
>>>>> Hello Jagan,
>>>>>
>>>>> Am 22.12.2014 09:58, schrieb Jagan Teki:
>>>>>>
>>>>>>
>>>>>> On 18 December 2014 at 19:21, Jagannadha Sutradharudu Teki
>>>>>> <jagannadh.teki@gmail.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> This reverts commit 562f8df18da62ae02c4ace1e530451fe82c3312d.
>>>>>>>
>>>>>>> Never see the issue with N25Q128 flash without need of W#/Vpp signal
>>>>>>> during probe.
>>>>>>>
>>>>>>> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
>>>>>>> Cc: Heiko Schocher <hs@denx.de>
>>>>>>> ---
>>>>>>>     README                        | 11 -----------
>>>>>>>     drivers/mtd/spi/sf_internal.h |  4 ----
>>>>>>>     drivers/mtd/spi/sf_probe.c    | 30 ------------------------------
>>>>>>>     3 files changed, 45 deletions(-)
>>>>>
>>>>>
>>>>>
>>>>> I found this issue on the aristainetos board, there the "W#/Vpp" signal
>>>>> is connected to a gpio pin.
>>>>
>>>>
>>>> Did you test the same board on Linux? what about the status there?
>>
>>
>> You can revert this patch. It seems it works not as expected, so it
>> is better to revert it, and I maybe get time for reworking it.
>
> Ok, Shall I apply this revert patch?

Yes, please.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2015-04-23 13:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 13:51 [U-Boot] [PATCH] Revert "spi: add config option to enable the WP pin function on st micron flashes" Jagannadha Sutradharudu Teki
2014-12-22  8:58 ` Jagan Teki
2014-12-23  6:34   ` Heiko Schocher
2014-12-23  8:15     ` Jagan Teki
2015-04-22 11:03       ` Jagan Teki
2015-04-23  5:39         ` Heiko Schocher
2015-04-23 12:58         ` Heiko Schocher
2015-04-23 13:06           ` Jagan Teki
2015-04-23 13:09             ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5538EF19.8070702@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox