From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 23 Apr 2015 15:09:45 +0200 Subject: [U-Boot] [PATCH] Revert "spi: add config option to enable the WP pin function on st micron flashes" In-Reply-To: References: <1418910666-25180-1-git-send-email-jagannadh.teki@gmail.com> <54990CFD.9070202@denx.de> <5538EC86.9040404@denx.de> Message-ID: <5538EF19.8070702@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Jagan, Am 23.04.2015 15:06, schrieb Jagan Teki: > On 23 April 2015 at 18:28, Heiko Schocher wrote: >> Hello Jagan, >> >> Am 22.04.2015 13:03, schrieb Jagan Teki: >>> >>> On 23 December 2014 at 13:45, Jagan Teki wrote: >>>> >>>> Hi Heiko, >>>> >>>> On 23 December 2014 at 12:04, Heiko Schocher wrote: >>>>> >>>>> Hello Jagan, >>>>> >>>>> Am 22.12.2014 09:58, schrieb Jagan Teki: >>>>>> >>>>>> >>>>>> On 18 December 2014 at 19:21, Jagannadha Sutradharudu Teki >>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> This reverts commit 562f8df18da62ae02c4ace1e530451fe82c3312d. >>>>>>> >>>>>>> Never see the issue with N25Q128 flash without need of W#/Vpp signal >>>>>>> during probe. >>>>>>> >>>>>>> Signed-off-by: Jagannadha Sutradharudu Teki >>>>>>> Cc: Heiko Schocher >>>>>>> --- >>>>>>> README | 11 ----------- >>>>>>> drivers/mtd/spi/sf_internal.h | 4 ---- >>>>>>> drivers/mtd/spi/sf_probe.c | 30 ------------------------------ >>>>>>> 3 files changed, 45 deletions(-) >>>>> >>>>> >>>>> >>>>> I found this issue on the aristainetos board, there the "W#/Vpp" signal >>>>> is connected to a gpio pin. >>>> >>>> >>>> Did you test the same board on Linux? what about the status there? >> >> >> You can revert this patch. It seems it works not as expected, so it >> is better to revert it, and I maybe get time for reworking it. > > Ok, Shall I apply this revert patch? Yes, please. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany