From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 23 Apr 2015 20:26:02 +0200 Subject: [U-Boot] [PATCH 5/5] mx6cuboxi: Load the correct 'fdt_file' variable In-Reply-To: References: <1429761426-26748-1-git-send-email-festevam@gmail.com> <1429761426-26748-5-git-send-email-festevam@gmail.com> <55388D71.3030503@denx.de> Message-ID: <5539393A.2080804@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, On 23/04/2015 19:18, Fabio Estevam wrote: >> What about to export your is_hummingboard() function as U-Boot command ? >> You can then use it in U-Boot scripts, and the correct fdt name can be >> set in the "bootcmd" variable. Something like "if is_humming;then ..." > > I am not sure how I can retrieve the returned value from > is_hummingboard() as a U-boot command and use it inside a script? > Maybe I did not understand your suggestion. Please advise. U_BOOT_CMD returns a value that can be evaluated, exactly as we do with "if tftp.." or for other commands. So you could implement: U_BOOT_CMD(is_hummingbird, 1, 1, do_is_hummingbird, .. and the do_is_hummingbird can return CMD_RET_SUCCESS or CMD_RET_FAILURE. This is then evaluated in the script as "if is_hummingbird;then fdt_file=....;else fdt_file=...;fi" > >> And if a user wants to use other names, he can because it is not hard-coded. > > Yes, I understand the concern, but in this specific case we are > talking about a DTB file, which is board specific and cannot really > change. Well, maybe I am alone, but I am used to have several DTB files during the developmnet phase - I agree with you that at the end there should be only one DTB file. Anyway, my was only a proposal - it is also fine if you decide to maintain the current implementation. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================