[U-Boot] [PATCH 16/19] trats2: config: enable dm pmic, dm regulator api, dm max77686

Przemyslaw Marczak
2014-10-10T13:50:50Z

Hello,

On 10/10/2014 05:40 AM, Simon Glass wrote:
> Hi,
>
> On 8 October 2014 14:48, Przemyslaw Marczak <p.marczak@samsung.com> wrote:
>> This change enables the configs required to init and setup
>> max77686 regulator driver, using the new driver model pmic API.
>>
>> Enabled configs:
>> - CONFIG_DM_PMIC
>> - CONFIG_DM_PMIC_MAX77686
>> - CONFIG_DM_PMIC_I2C
>> - CONFIG_DM_REGULATOR
>> - CONFIG_DM_REGULATOR_MAX77686
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> ---
>> include/configs/trats2.h | 14 ++++++--------
>> 1 file changed, 6 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/configs/trats2.h b/include/configs/trats2.h
>> index 42481ab..6d04498 100644
>> --- a/include/configs/trats2.h
>> +++ b/include/configs/trats2.h
>> @@ -185,13 +185,11 @@ int get_soft_i2c_sda_pin(void);
>> #define CONFIG_SOFT_I2C_GPIO_SDA get_soft_i2c_sda_pin()
>>
>> /* POWER */
>> -#define CONFIG_POWER
>> -#define CONFIG_POWER_I2C
>> -#define CONFIG_POWER_MAX77686
>> -#define CONFIG_POWER_PMIC_MAX77693
>> -#define CONFIG_POWER_MUIC_MAX77693
>> -#define CONFIG_POWER_FG_MAX77693
>> -#define CONFIG_POWER_BATTERY_TRATS2
>> +#define CONFIG_DM_PMIC
>> +#define CONFIG_DM_PMIC_MAX77686
>> +#define CONFIG_DM_PMIC_I2C
>> +#define CONFIG_DM_REGULATOR
>> +#define CONFIG_DM_REGULATOR_MAX77686
>>
>> /* Security subsystem - enable hw_rand() */
>> #define CONFIG_EXYNOS_ACE_SHA
>> @@ -210,7 +208,7 @@ int get_soft_i2c_sda_pin(void);
>> #ifndef __ASSEMBLY__
>> #include <power/max77686_pmic.h>
>>
>> -#define KEY_PWR_PMIC_NAME "MAX77686_PMIC"
>> +#define KEY_PWR_PMIC_NAME "max77686"
>> #define KEY_PWR_STATUS_REG MAX77686_REG_PMIC_STATUS1
>> #define KEY_PWR_STATUS_MASK (1 << 0)
>> #define KEY_PWR_INTERRUPT_REG MAX77686_REG_PMIC_INT1
>> --
>> 1.9.1
>>
>
> I suppose at some point we should start putting these into Kconfig
> board trats_defconfig instead of board config files.
>
> Regards,
> Simon
>
You, know - the aim of PMIC framework is to support such feature as
something common - so this should be some device soon. I think that we
can leave it here temporary.

Thanks,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com