[U-Boot] [PATCH v3 10/17] dm: pmic: add max77686 pmic driver

Simon Glass
2015-03-29T13:08:25Z

Hi Przemyslaw,

On 24 March 2015 at 14:30, Przemyslaw Marczak <p.marczak@samsung.com> wrote:
> This is the implementation of driver model uclass pmic driver.
> The max77686 pmic driver implements read/write operations and driver
> bind method - to bind other pmic uclass devices as a parent pmic device.
> This driver provides pmic_platdata for also for child regulator.
>
> This driver will try to bind the regulator device with regulator driver.
> This should succeed if regulator driver is compiled.
>
> If no regulator driver found, then the pmic can still provide read/write
> operations, and can be used with pmic framework function calls.
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>

Acked-by: Simon Glass <sjg@chromium.org>

One nit below.

> ---
> Changes V2:
> - add implementation of pmic read/write
> - max77686: add new operations
> - max77686: header: change PMIC_NUM_OF_REGS to MAX77686_NUM_OF_REGS
>
> Changes V3:
> - pmic/max77686.c: call pmic_child_node_scan() to bind regulator device
> - remove use of pmic platdata
> - remove unused endian conversions
> - Kconfig: add max77686 pmic entry
> ---
> drivers/power/Kconfig | 7 ++++
> drivers/power/pmic/Makefile | 1 +
> drivers/power/pmic/max77686.c | 76 ++++++++++++++++++++++++++++++++++++++
> drivers/power/pmic/pmic_max77686.c | 2 +-
> include/power/max77686_pmic.h | 2 +-
> 5 files changed, 86 insertions(+), 2 deletions(-)
> create mode 100644 drivers/power/pmic/max77686.c
>
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 1e73c7a..c4d4c72 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -66,6 +66,13 @@ config DM_PMIC
> So the call will looks like below:
> 'pmic_write(regulator->parent, addr, value, len);'
>
> +config DM_PMIC_MAX77686
> + bool "Enable Driver Model for PMIC MAX77686"
> + depends on DM_PMIC
> + ---help---
> + This config enables implementation of driver-model pmic uclass features
> + for PMIC MAX77686. The driver implements read/write operations/

nit: '.' at end?

Regards,
Simon