[U-Boot] [PATCH 01/19] lib: errno: introduce errno_str(): returns errno related message

Joakim Tjernlund
2014-10-10T05:03:44Z

Przemyslaw Marczak <p.marczak@samsung.com> wrote on 2014/10/09 18:23:54:
>
> Hello Joakim,
>
> On 10/09/2014 08:46 AM, Joakim Tjernlund wrote:
> >> From: Przemyslaw Marczak <p.marczak@samsung.com>
> >>
> >> The functions error's numbers are standarized - but the error
> >> messages are not.
> >>
> >> The errors are often handled with unclear error messages,
> >> so why not use an errno standarized messages.
> >>
> >> Advantages:
> >> - This could decrease the binary size.
> >
> > Having an array of string ptrs adds some extra space needs.
> > Each str needs a ptr and that ptr needs relocation, 8 bytes on 32 bits
> >
> > If you want to save space do this instead
> > static const char const errno_message[] =
> > "Success\0Operation not permitted\0No such file or directory" etc.
> > Then count "\0" to find the error msg.
> >
> > Jocke
> >
>
> Is this really a problem to add some array with the pointers?

Probably not, I only mentioned this because you claimed it could reduces
size
as if that was important to you.

Jocke

>
> You are right, this array requires some additional space, but this is
> not the main reason of introducing this function. This can be enabled
> optional, so maybe for the less memory and slower devices this shouldn't

> be used - but in the other way, we see many text messages in the code
> that could be replaced with the one from that array.
> So, which is better?
>
> This helps me sometimes, so I added this as some extra feature.