From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/21] sunxi: usbc: Fix vbus gpio handling to work with the device-model
Date: Fri, 24 Apr 2015 20:15:07 +0200 [thread overview]
Message-ID: <553A882B.4010006@redhat.com> (raw)
In-Reply-To: <CAOMZO5AFVATn1JSkkpBrdUr0ZAuomoH9OPqm7SATsKGCjy6cPQ@mail.gmail.com>
Hi,
On 24-04-15 20:10, Fabio Estevam wrote:
> On Fri, Apr 24, 2015 at 10:48 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>
>> sunxi_usbc->gpio_vbus = get_vbus_gpio(index);
>> - if (sunxi_usbc->gpio_vbus != -1) {
>> + if (sunxi_usbc->gpio_vbus >= 0) {
>
> What about using dm_gpio_is_valid() instead?
dm_gpio_is_valid takes a struct gpio_desc *, where as this code is using
good old gpio indexes (int). We will likely want to convert this to getting
the gpio from devicetree directly in the future, but first we need this
patch-set to convert all sunxi boards to the device-model, so that we can
make such changes without the need to introduce a whole lot of #ifdef-s
Regards,
Hans
next prev parent reply other threads:[~2015-04-24 18:15 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 13:48 [U-Boot] [PATCH 00/21] sunxi: Move ALL boards to the device-model Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 01/21] sunxi: Do not build i2c support when we've no i2c controllers Hans de Goede
2015-04-24 23:22 ` Simon Glass
2015-04-25 8:29 ` Hans de Goede
2015-04-26 3:14 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 02/21] sunxi: mmc: Fix card-detect gpio handling to work with the device-model Hans de Goede
2015-04-24 23:23 ` Simon Glass
2015-04-26 3:15 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 03/21] sunxi: usbc: Fix vbus " Hans de Goede
2015-04-24 18:10 ` Fabio Estevam
2015-04-24 18:15 ` Hans de Goede [this message]
2015-04-24 23:23 ` Simon Glass
2015-04-26 3:16 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 04/21] sunxi: display: Fix " Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:17 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 05/21] sunxi: soft-i2c: " Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:18 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 06/21] sunxi: gpio: Rename GPIOs to include a 'P' prefix Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 07/21] sunxi: gpio: Add temporary implementation of name_to_gpio() Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 08/21] sunxi: gpio: Add compatible strings for all supported SoCs Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:19 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 09/21] sunxi: gpio: Build sunxi_name_to_gpio_bank for device-model code too Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:21 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 10/21] sunxi: gpio: Change axp_gpio_foo prototype to match gpio uclass ops Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-24 13:48 ` [U-Boot] [PATCH 11/21] sunxi: gpio: Add support for AXP gpios to the dm gpio code Hans de Goede
2015-04-24 13:54 ` Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-24 13:48 ` [U-Boot] [PATCH 12/21] sunxi: gmac: Move sunxi_gmac_initialize proto out of netdev.h Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:23 ` Ian Campbell
2015-04-26 9:55 ` Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 13/21] sunxi: emac: port to phylib Hans de Goede
2015-04-26 3:24 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 14/21] sunxi: emac: Prepare for device-model support Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 15/21] sunxi: emac: Add device model support Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-25 8:39 ` Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 16/21] sunxi: dts: Sync all dts files with upstream kernel Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:27 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 17/21] sunxi: dts: Add dts files which have been submitted but not yet merged upstream Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:27 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 18/21] sunxi: dts: Add minimal dts files for board which lack a dts sofar Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:30 ` Ian Campbell
2015-04-26 9:57 ` Hans de Goede
2015-05-02 13:48 ` Ian Campbell
2015-05-04 14:12 ` Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 19/21] sunxi: dts: Add a CONFIG_DEFAULT_DEVICE_TREE setting to all sunxi boards Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:31 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 20/21] sunxi: Move all boards to the device-model Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:33 ` Ian Campbell
2015-04-26 10:06 ` Hans de Goede
2015-05-02 13:49 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 21/21] sunxi: emac: Remove non device-model code Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:33 ` Ian Campbell
2015-04-24 23:23 ` [U-Boot] [PATCH 00/21] sunxi: Move ALL boards to the device-model Simon Glass
2015-04-25 8:27 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553A882B.4010006@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox