From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/21] sunxi: Do not build i2c support when we've no i2c controllers
Date: Sat, 25 Apr 2015 10:29:02 +0200 [thread overview]
Message-ID: <553B504E.2030503@redhat.com> (raw)
In-Reply-To: <CAPnjgZ3Lod4FNYfAcz2xAeb+JKgAEr2PCufX=xW2vR+dWA+MtQ@mail.gmail.com>
Hi,
On 25-04-15 01:22, Simon Glass wrote:
> Hi Hans,
>
> On 24 April 2015 at 07:48, Hans de Goede <hdegoede@redhat.com> wrote:
>> This fixes the following errors being printed during boot:
>>
>> Error, wrong i2c adapter 0 max 0 possible
>> Error, wrong i2c adapter 0 max 0 possible
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Where does the error come from?
Somewhere in the i2c code I presume, I did not investigate, I started
by trying to simply disable building the i2c stuff as it makes no sense
to have i2c support build-in when there are no controllers, and that
indeed fixed things.
Regards,
Hans
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
>> ---
>> include/configs/sunxi-common.h | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
>> index 3e49aba..f97e626 100644
>> --- a/include/configs/sunxi-common.h
>> +++ b/include/configs/sunxi-common.h
>> @@ -261,14 +261,15 @@
>> #define CONFIG_SPL_I2C_SUPPORT
>> #endif
>>
>> -#define CONFIG_SYS_I2C
>> #if defined CONFIG_I2C0_ENABLE || defined CONFIG_I2C1_ENABLE || \
>> defined CONFIG_I2C2_ENABLE || defined CONFIG_I2C3_ENABLE || \
>> defined CONFIG_I2C4_ENABLE
>> +#define CONFIG_SYS_I2C
>> #define CONFIG_SYS_I2C_MVTWSI
>> -#endif
>> #define CONFIG_SYS_I2C_SPEED 400000
>> #define CONFIG_SYS_I2C_SLAVE 0x7f
>> +#define CONFIG_CMD_I2C
>> +#endif
>>
>> #if defined CONFIG_VIDEO_LCD_PANEL_I2C && !(defined CONFIG_SPL_BUILD)
>> #define CONFIG_SYS_I2C_SOFT
>> @@ -288,8 +289,6 @@ extern int soft_i2c_gpio_scl;
>> #define CONFIG_VIDEO_LCD_I2C_BUS -1 /* NA, but necessary to compile */
>> #endif
>>
>> -#define CONFIG_CMD_I2C
>> -
>> /* PMU */
>> #if defined CONFIG_AXP152_POWER || defined CONFIG_AXP209_POWER || defined CONFIG_AXP221_POWER
>> #define CONFIG_SPL_POWER_SUPPORT
>> --
>> 2.3.5
>>
>
> Regards,
> Simon
>
next prev parent reply other threads:[~2015-04-25 8:29 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 13:48 [U-Boot] [PATCH 00/21] sunxi: Move ALL boards to the device-model Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 01/21] sunxi: Do not build i2c support when we've no i2c controllers Hans de Goede
2015-04-24 23:22 ` Simon Glass
2015-04-25 8:29 ` Hans de Goede [this message]
2015-04-26 3:14 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 02/21] sunxi: mmc: Fix card-detect gpio handling to work with the device-model Hans de Goede
2015-04-24 23:23 ` Simon Glass
2015-04-26 3:15 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 03/21] sunxi: usbc: Fix vbus " Hans de Goede
2015-04-24 18:10 ` Fabio Estevam
2015-04-24 18:15 ` Hans de Goede
2015-04-24 23:23 ` Simon Glass
2015-04-26 3:16 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 04/21] sunxi: display: Fix " Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:17 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 05/21] sunxi: soft-i2c: " Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:18 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 06/21] sunxi: gpio: Rename GPIOs to include a 'P' prefix Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 07/21] sunxi: gpio: Add temporary implementation of name_to_gpio() Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 08/21] sunxi: gpio: Add compatible strings for all supported SoCs Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:19 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 09/21] sunxi: gpio: Build sunxi_name_to_gpio_bank for device-model code too Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:21 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 10/21] sunxi: gpio: Change axp_gpio_foo prototype to match gpio uclass ops Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-24 13:48 ` [U-Boot] [PATCH 11/21] sunxi: gpio: Add support for AXP gpios to the dm gpio code Hans de Goede
2015-04-24 13:54 ` Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-24 13:48 ` [U-Boot] [PATCH 12/21] sunxi: gmac: Move sunxi_gmac_initialize proto out of netdev.h Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:23 ` Ian Campbell
2015-04-26 9:55 ` Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 13/21] sunxi: emac: port to phylib Hans de Goede
2015-04-26 3:24 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 14/21] sunxi: emac: Prepare for device-model support Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 15/21] sunxi: emac: Add device model support Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-25 8:39 ` Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 16/21] sunxi: dts: Sync all dts files with upstream kernel Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:27 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 17/21] sunxi: dts: Add dts files which have been submitted but not yet merged upstream Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:27 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 18/21] sunxi: dts: Add minimal dts files for board which lack a dts sofar Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:30 ` Ian Campbell
2015-04-26 9:57 ` Hans de Goede
2015-05-02 13:48 ` Ian Campbell
2015-05-04 14:12 ` Hans de Goede
2015-04-24 13:48 ` [U-Boot] [PATCH 19/21] sunxi: dts: Add a CONFIG_DEFAULT_DEVICE_TREE setting to all sunxi boards Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:31 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 20/21] sunxi: Move all boards to the device-model Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:33 ` Ian Campbell
2015-04-26 10:06 ` Hans de Goede
2015-05-02 13:49 ` Ian Campbell
2015-04-24 13:48 ` [U-Boot] [PATCH 21/21] sunxi: emac: Remove non device-model code Hans de Goede
2015-04-24 23:24 ` Simon Glass
2015-04-26 3:33 ` Ian Campbell
2015-04-24 23:23 ` [U-Boot] [PATCH 00/21] sunxi: Move ALL boards to the device-model Simon Glass
2015-04-25 8:27 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553B504E.2030503@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox