From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Sat, 25 Apr 2015 10:29:02 +0200 Subject: [U-Boot] [PATCH 01/21] sunxi: Do not build i2c support when we've no i2c controllers In-Reply-To: References: <1429883310-22441-1-git-send-email-hdegoede@redhat.com> <1429883310-22441-2-git-send-email-hdegoede@redhat.com> Message-ID: <553B504E.2030503@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 25-04-15 01:22, Simon Glass wrote: > Hi Hans, > > On 24 April 2015 at 07:48, Hans de Goede wrote: >> This fixes the following errors being printed during boot: >> >> Error, wrong i2c adapter 0 max 0 possible >> Error, wrong i2c adapter 0 max 0 possible >> >> Signed-off-by: Hans de Goede > > Where does the error come from? Somewhere in the i2c code I presume, I did not investigate, I started by trying to simply disable building the i2c stuff as it makes no sense to have i2c support build-in when there are no controllers, and that indeed fixed things. Regards, Hans > > Reviewed-by: Simon Glass > >> --- >> include/configs/sunxi-common.h | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h >> index 3e49aba..f97e626 100644 >> --- a/include/configs/sunxi-common.h >> +++ b/include/configs/sunxi-common.h >> @@ -261,14 +261,15 @@ >> #define CONFIG_SPL_I2C_SUPPORT >> #endif >> >> -#define CONFIG_SYS_I2C >> #if defined CONFIG_I2C0_ENABLE || defined CONFIG_I2C1_ENABLE || \ >> defined CONFIG_I2C2_ENABLE || defined CONFIG_I2C3_ENABLE || \ >> defined CONFIG_I2C4_ENABLE >> +#define CONFIG_SYS_I2C >> #define CONFIG_SYS_I2C_MVTWSI >> -#endif >> #define CONFIG_SYS_I2C_SPEED 400000 >> #define CONFIG_SYS_I2C_SLAVE 0x7f >> +#define CONFIG_CMD_I2C >> +#endif >> >> #if defined CONFIG_VIDEO_LCD_PANEL_I2C && !(defined CONFIG_SPL_BUILD) >> #define CONFIG_SYS_I2C_SOFT >> @@ -288,8 +289,6 @@ extern int soft_i2c_gpio_scl; >> #define CONFIG_VIDEO_LCD_I2C_BUS -1 /* NA, but necessary to compile */ >> #endif >> >> -#define CONFIG_CMD_I2C >> - >> /* PMU */ >> #if defined CONFIG_AXP152_POWER || defined CONFIG_AXP209_POWER || defined CONFIG_AXP221_POWER >> #define CONFIG_SPL_POWER_SUPPORT >> -- >> 2.3.5 >> > > Regards, > Simon >