From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Sun, 26 Apr 2015 11:55:06 +0200 Subject: [U-Boot] [PATCH 12/21] sunxi: gmac: Move sunxi_gmac_initialize proto out of netdev.h In-Reply-To: <1430018608.12403.71.camel@hellion.org.uk> References: <1429883310-22441-1-git-send-email-hdegoede@redhat.com> <1429883310-22441-13-git-send-email-hdegoede@redhat.com> <1430018608.12403.71.camel@hellion.org.uk> Message-ID: <553CB5FA.7080806@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Thanks for the reviews! On 26-04-15 05:23, Ian Campbell wrote: > On Fri, 2015-04-24 at 15:48 +0200, Hans de Goede wrote: >> netdev.h should not be included in device-model enabled builds (doing so >> causes compiler warnings about struct eth_device not being declared), but >> we do use sunxi_gmac_initialize in the device-model case, so move it out of >> netdev.h . > > Worth keeping the emac one alongside? It gets completely removed in "sunxi: emac: Remove non device-model code" :) Regards, Hans