From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Sun, 26 Apr 2015 12:06:44 +0200 Subject: [U-Boot] [PATCH 20/21] sunxi: Move all boards to the device-model In-Reply-To: <1430019200.12403.79.camel@hellion.org.uk> References: <1429883310-22441-1-git-send-email-hdegoede@redhat.com> <1429883310-22441-21-git-send-email-hdegoede@redhat.com> <1430019200.12403.79.camel@hellion.org.uk> Message-ID: <553CB8B4.4070500@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 26-04-15 05:33, Ian Campbell wrote: > On Fri, 2015-04-24 at 15:48 +0200, Hans de Goede wrote: >> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig >> index 3831d3b..3997637 100644 >> --- a/board/sunxi/Kconfig >> +++ b/board/sunxi/Kconfig >> @@ -529,4 +529,16 @@ config GMAC_TX_DELAY >> ---help--- >> Set the GMAC Transmit Clock Delay Chain value. >> >> +config NET >> + default y >> + >> +config NETDEVICES >> + default y >> + >> +config DM_ETH >> + default y >> + >> +config DM_SERIAL >> + default y > > None of these have a more appropriate home than sunxi/Kconfig? The CONFIG_foo options themselves are defined in more appropriate places, we are just enabling them for all sunxi boards here. Another way would be to add "default y if ARCH_SUNXI" to the place where they are actually defined. Doing things this way was copied from arch/sandbox/Kconfig, I've tried using select in arch/arm/Kconfig for the NET ones but that leads to: warning: (ARCH_SUNXI) selects NET which has unmet direct dependencies (SANDBOX) warning: (ARCH_SUNXI) selects NET which has unmet direct dependencies (SANDBOX) Which really seems to be an issue with the SANDBOX Kconfig file to me, which has: menu "Sandbox architecture" depends on SANDBOX ... config NET default y config NETDEVICES default y config DM_ETH default y ... endmenu I would be happy to see this fixed, but for now I've just copied what the sandbox code is doing. Regards, Hans