[U-Boot] [PATCH 05/11] env: Simplify the reverse_strstr() interface

Joe Hershberger
2015-04-27T19:24:25Z

Hi Simon,

On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass <sjg@chromium.org> wrote:
> Hi Joe,
>
> On 21 April 2015 at 16:02, Joe Hershberger <joe.hershberger@ni.com> wrote:
>> The logic to find the whole matching name was split needlessly between
>> the reverse_strstr function and its caller. Fully contain it to make the
>> interface for calling it more consistent.
>>
>> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
>> ---
>>
>> common/env_attr.c | 79 +++++++++++++++++++++++++++++--------------------------
>> 1 file changed, 41 insertions(+), 38 deletions(-)
>>
>
> You could perhaps add some environment tests in test/ for this
> function, or access it through getenv(), etc.

I'll look into adding some unit tests for the env stuff.

Cheers,
-Joe