[U-Boot] [PATCH v3 18/26] test: dm: eth: Handle failed test env cleanup

Simon Glass
2015-05-06T15:11:46Z

Hi Joe,

On 5 May 2015 at 17:39, Joe Hershberger <joe.hershberger@gmail.com> wrote:
> Hi Simon,
>
> On Tue, May 5, 2015 at 3:56 PM, Simon Glass <sjg@chromium.org> wrote:
>> Hi Joe,
>>
>> On 3 May 2015 at 14:12, Joe Hershberger <joe.hershberger@ni.com> wrote:
>>> Make sure that the env gets cleaned up after a test fails so that other
>>> tests aren't affected.
>>>
>>> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
>>> ---
>>>
>>> Changes in v3:
>>> -New for version 3
>>>
>>> Changes in v2: None
>>>
>>> test/dm/eth.c | 79 +++++++++++++++++++++++++++++++++++++++++------------------
>>> 1 file changed, 55 insertions(+), 24 deletions(-)
>>
>> With this commit I get quite a few errors, like:
>>
>> 19: test: dm: eth: Handle failed test env cleanup
>> sandbox: + sandbox
>> + int retval;
>> + ^
>> +test/dm/built-in.o: In function `dm_test_bus_children':
>> +build/../test/dm/bus.c:121: undefined reference to `ut_failf'
>> +build/../test/dm/bus.c:123: undefined reference to `ut_fail'
>> +test/dm/built-in.o: In function `dm_test_bus_children_funcs':
>> +build/../test/dm/bus.c:143: undefined reference to `ut_failf'
>> +build/../test/dm/bus.c:168: undefined reference to `ut_failf'
>> +build/../test/dm/bus.c:169: undefined reference to `ut_fail'
>
> Are you sure it's this commit? This touches nothing it test/dm/bus.c
> and nothing in test/ut.c (where those functions are defined). Is is
> maybe a dirty build error?

buildman does not lie :-) Well, so far as I know...it retries if it
sees any errors and warnings, after doing a full mrproper.

Just to be sure I tried a separate sandbox build and got the same errors.

I pushed the tree to u-boot-dm branch 'env-working' - perhaps I've
applied something incorrectly?

Regards,
Simon