[U-Boot] [PATCH v4 00/26] Improve env var handling for net stack

Joe Hershberger
2015-05-21T13:50:21Z

Hi Tom,

On Thu, May 21, 2015 at 8:33 AM, Tom Rini <trini@konsulko.com> wrote:
> On Wed, May 20, 2015 at 02:38:05PM -0500, Joe Hershberger wrote:
>> Hi Tom,
>>
>> On Wed, May 20, 2015 at 9:58 AM, Tom Rini <trini@konsulko.com> wrote:
>> > On Thu, May 07, 2015 at 04:48:51AM -0500, Joe Hershberger wrote:
>> >
>> >> This includes moving CONFIG_REGEX to Kconfig and adding support for
>> >> regex to the env_attr lists (when CONFIG_REGEX is enabled).
>> >>
>> >> This allows ethaddrs to all be checked for access and format by default.
>> >> Also use callbacks to keep network stack variables up to date instead of
>> >> polling them on each call to net_loop.
>> >>
>> >> This is a step in the right direction to refactoring the network stack
>> >> to be similar to that of barebox.
>> >>
>> >> Also added a test command to host unit tests for the env functions.
>> >
>> > Can you do a v5 on top of master please? The config changes fail pretty
>> > badly, thanks!
>>
>> I just noticed that this also conflicts a bit with u-boot-net/master.
>> Should I push it there and send a new PR?
>
> I had to think when applying #13 (so please check when I push)

OK, will do.

> but I gave omap4_panda (a usb eth setup) a quick try and it's still working so
> I think we're good. I assume you're taking care of usbethaddr in these
> changes :).

In driver model, usbethaddr is not handled uniquely, it is just
another "eth" so it will use a numbered eth%daddr.

This series does not touch the usbethaddr support for existing boards.

> I also tested on am335x GP EVM (SoC ethernet) and that
> still works too.

Great!

-Joe