From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Sun, 03 May 2015 10:40:40 -0600 Subject: [U-Boot] [PATCH] u-boot: adjust config_cmd_default.h not to raise ton of warnings In-Reply-To: <20150503100134.GA25636@amd> References: <20150501091411.GB7205@amd> <55439A92.1050009@wwwdotorg.org> <20150503100134.GA25636@amd> Message-ID: <55464F88.7010900@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/03/2015 04:01 AM, Pavel Machek wrote: > On Fri 2015-05-01 09:24:02, Stephen Warren wrote: >> On 05/01/2015 03:14 AM, Pavel Machek wrote: >>> >>> If there's duplicty between config system and config_cmd_default, a >>> ton of warnings is raised, because one uses plain defines, and other >>> defines it to 1. Adjust config_cmd_default.h not to provoke the >>> warnings. >> >> I believe the correct way to fix this is to fix the board config files that >> cause the defines to be duplicated. > > Yes, I'm doing that, too (patch is waiting for Marek to be applied), > but that does not really fix the problem -- it really should be > consistent; otherwise we'll hit subtle bugs sooner or later. I don't believe consistency requires complicating the defaults file.