* [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1
2015-05-04 14:22 [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem Fabio Estevam
@ 2015-05-04 14:22 ` Fabio Estevam
2015-05-04 14:51 ` Stefano Babic
` (3 more replies)
2015-05-04 14:51 ` [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem Stefano Babic
` (3 subsequent siblings)
4 siblings, 4 replies; 10+ messages in thread
From: Fabio Estevam @ 2015-05-04 14:22 UTC (permalink / raw)
To: u-boot
Configure PAD_ENET_RXD0/RXD1 pads as pull down because these pads are directly
connected to the Atheros 8035/8030 although they should be functional
only in the RMII mode - 8030.
Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- None
board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
index ff018e1..8fb6004 100644
--- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
+++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
@@ -134,6 +134,8 @@ static iomux_v3_cfg_t const enet_pads[] = {
IOMUX_PADS(PAD_RGMII_RD2__RGMII_RD2 | MUX_PAD_CTRL(ENET_PAD_CTRL)),
IOMUX_PADS(PAD_RGMII_RD3__RGMII_RD3 | MUX_PAD_CTRL(ENET_PAD_CTRL)),
IOMUX_PADS(PAD_RGMII_RX_CTL__RGMII_RX_CTL | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
+ IOMUX_PADS(PAD_ENET_RXD0__GPIO1_IO27 | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
+ IOMUX_PADS(PAD_ENET_RXD1__GPIO1_IO26 | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
};
static void setup_iomux_enet(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1
2015-05-04 14:22 ` [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1 Fabio Estevam
@ 2015-05-04 14:51 ` Stefano Babic
2015-05-04 14:56 ` Tom Rini
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Stefano Babic @ 2015-05-04 14:51 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 04/05/2015 16:22, Fabio Estevam wrote:
> Configure PAD_ENET_RXD0/RXD1 pads as pull down because these pads are directly
> connected to the Atheros 8035/8030 although they should be functional
> only in the RMII mode - 8030.
>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - None
> board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> index ff018e1..8fb6004 100644
> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> @@ -134,6 +134,8 @@ static iomux_v3_cfg_t const enet_pads[] = {
> IOMUX_PADS(PAD_RGMII_RD2__RGMII_RD2 | MUX_PAD_CTRL(ENET_PAD_CTRL)),
> IOMUX_PADS(PAD_RGMII_RD3__RGMII_RD3 | MUX_PAD_CTRL(ENET_PAD_CTRL)),
> IOMUX_PADS(PAD_RGMII_RX_CTL__RGMII_RX_CTL | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
> + IOMUX_PADS(PAD_ENET_RXD0__GPIO1_IO27 | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
> + IOMUX_PADS(PAD_ENET_RXD1__GPIO1_IO26 | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
> };
>
> static void setup_iomux_enet(void)
>
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread* [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1
2015-05-04 14:22 ` [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1 Fabio Estevam
2015-05-04 14:51 ` Stefano Babic
@ 2015-05-04 14:56 ` Tom Rini
2015-05-04 16:03 ` Vagrant Cascadian
2015-05-04 16:09 ` Stefano Babic
3 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2015-05-04 14:56 UTC (permalink / raw)
To: u-boot
On Mon, May 04, 2015 at 11:22:56AM -0300, Fabio Estevam wrote:
> Configure PAD_ENET_RXD0/RXD1 pads as pull down because these pads are directly
> connected to the Atheros 8035/8030 although they should be functional
> only in the RMII mode - 8030.
>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150504/375015b0/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1
2015-05-04 14:22 ` [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1 Fabio Estevam
2015-05-04 14:51 ` Stefano Babic
2015-05-04 14:56 ` Tom Rini
@ 2015-05-04 16:03 ` Vagrant Cascadian
2015-05-04 16:09 ` Stefano Babic
3 siblings, 0 replies; 10+ messages in thread
From: Vagrant Cascadian @ 2015-05-04 16:03 UTC (permalink / raw)
To: u-boot
On 2015-05-04, Fabio Estevam wrote:
> Configure PAD_ENET_RXD0/RXD1 pads as pull down because these pads are directly
> connected to the Atheros 8035/8030 although they should be functional
> only in the RMII mode - 8030.
>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - None
> board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> index ff018e1..8fb6004 100644
> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> @@ -134,6 +134,8 @@ static iomux_v3_cfg_t const enet_pads[] = {
> IOMUX_PADS(PAD_RGMII_RD2__RGMII_RD2 | MUX_PAD_CTRL(ENET_PAD_CTRL)),
> IOMUX_PADS(PAD_RGMII_RD3__RGMII_RD3 | MUX_PAD_CTRL(ENET_PAD_CTRL)),
> IOMUX_PADS(PAD_RGMII_RX_CTL__RGMII_RX_CTL | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
> + IOMUX_PADS(PAD_ENET_RXD0__GPIO1_IO27 | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
> + IOMUX_PADS(PAD_ENET_RXD1__GPIO1_IO26 | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
> };
>
> static void setup_iomux_enet(void)
> --
> 1.9.1
Tested on cubox-i4pro and hummingboard-i2ex.
Tested-By: Vagrant Cascadian <vagrant@aikidev.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150504/a8df287c/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread* [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1
2015-05-04 14:22 ` [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1 Fabio Estevam
` (2 preceding siblings ...)
2015-05-04 16:03 ` Vagrant Cascadian
@ 2015-05-04 16:09 ` Stefano Babic
3 siblings, 0 replies; 10+ messages in thread
From: Stefano Babic @ 2015-05-04 16:09 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 04/05/2015 16:22, Fabio Estevam wrote:
> Configure PAD_ENET_RXD0/RXD1 pads as pull down because these pads are directly
> connected to the Atheros 8035/8030 although they should be functional
> only in the RMII mode - 8030.
>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem
2015-05-04 14:22 [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem Fabio Estevam
2015-05-04 14:22 ` [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1 Fabio Estevam
@ 2015-05-04 14:51 ` Stefano Babic
2015-05-04 14:55 ` Tom Rini
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Stefano Babic @ 2015-05-04 14:51 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 04/05/2015 16:22, Fabio Estevam wrote:
> mx6cuboxi sometimes fails to recognize the Ethernet PHY:
>
> Net: Phy 0 not found
>
> The explanation for this behavior comes from from Rabeeh Khoury:
>
> "The LED_ACT pin on the carrier-one boards had a pull down that
> forces the phy address to 0x0; where on CuBox-i and the production
> HummingBoard that pin is connected directly to LED that depending
> on the pull down strength of the LED it might be sampled as '0' or '1' thus
> the phy address might appear as either address 0x0 or 0x4."
>
> "This is AR8035 implementation; in reset stage the LED pin is configured as
> input, and pull up/down does matter. In this case it configures the PHY
> address.
>
> After reset is deasserted the same LED pin becomes output and then
> according to the previous pull/up it should be active high/low"
>
> One way to properly fix this behavior is to place external pull-up/down
> resistors in the LED line, but from a software standpoint we can fix it
> by telling phy_find_by_mask() to scan the PHY at addresses
> 0x0 and 0x4.
>
> Reported-by: Vagrant Cascadian <vagrant@aikidev.net>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Explain what the proper hardware fix would be as suggested by Nikolay
> - Remove error message from fec_probe as this function already prints on error.
>
> board/solidrun/mx6cuboxi/mx6cuboxi.c | 29 ++++++++++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> index 9aa0259..e83d2fe 100644
> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> @@ -25,6 +25,7 @@
> #include <asm/imx-common/video.h>
> #include <mmc.h>
> #include <fsl_esdhc.h>
> +#include <malloc.h>
> #include <miiphy.h>
> #include <netdev.h>
> #include <asm/arch/crm_regs.h>
> @@ -152,9 +153,14 @@ int board_phy_config(struct phy_device *phydev)
> return 0;
> }
>
> +/* On Cuboxi Ethernet PHY can be located at addresses 0x0 or 0x4 */
> +#define ETH_PHY_MASK ((1 << 0x0) | (1 << 0x4))
> +
> int board_eth_init(bd_t *bis)
> {
> struct iomuxc *const iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR;
> + struct mii_dev *bus;
> + struct phy_device *phydev;
>
> int ret = enable_fec_anatop_clock(ENET_25MHZ);
> if (ret)
> @@ -165,7 +171,28 @@ int board_eth_init(bd_t *bis)
>
> setup_iomux_enet();
>
> - return cpu_eth_init(bis);
> + bus = fec_get_miibus(IMX_FEC_BASE, -1);
> + if (!bus)
> + return -EINVAL;
> +
> + phydev = phy_find_by_mask(bus, ETH_PHY_MASK, PHY_INTERFACE_MODE_RGMII);
> + if (!phydev) {
> + ret = -EINVAL;
> + goto free_bus;
> + }
> +
> + debug("using phy at address %d\n", phydev->addr);
> + ret = fec_probe(bis, -1, IMX_FEC_BASE, bus, phydev);
> + if (ret)
> + goto free_phydev;
> +
> + return 0;
> +
> +free_phydev:
> + free(phydev);
> +free_bus:
> + free(bus);
> + return ret;
> }
>
> #ifdef CONFIG_VIDEO_IPUV3
>
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread* [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem
2015-05-04 14:22 [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem Fabio Estevam
2015-05-04 14:22 ` [U-Boot] [PATCH v2 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1 Fabio Estevam
2015-05-04 14:51 ` [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem Stefano Babic
@ 2015-05-04 14:55 ` Tom Rini
2015-05-04 16:02 ` [U-Boot] [U-Boot, v2, " Vagrant Cascadian
2015-05-04 16:09 ` [U-Boot] [PATCH v2 " Stefano Babic
4 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2015-05-04 14:55 UTC (permalink / raw)
To: u-boot
On Mon, May 04, 2015 at 11:22:55AM -0300, Fabio Estevam wrote:
> mx6cuboxi sometimes fails to recognize the Ethernet PHY:
>
> Net: Phy 0 not found
>
> The explanation for this behavior comes from from Rabeeh Khoury:
>
> "The LED_ACT pin on the carrier-one boards had a pull down that
> forces the phy address to 0x0; where on CuBox-i and the production
> HummingBoard that pin is connected directly to LED that depending
> on the pull down strength of the LED it might be sampled as '0' or '1' thus
> the phy address might appear as either address 0x0 or 0x4."
>
> "This is AR8035 implementation; in reset stage the LED pin is configured as
> input, and pull up/down does matter. In this case it configures the PHY
> address.
>
> After reset is deasserted the same LED pin becomes output and then
> according to the previous pull/up it should be active high/low"
>
> One way to properly fix this behavior is to place external pull-up/down
> resistors in the LED line, but from a software standpoint we can fix it
> by telling phy_find_by_mask() to scan the PHY at addresses
> 0x0 and 0x4.
>
> Reported-by: Vagrant Cascadian <vagrant@aikidev.net>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [U-Boot, v2, 1/2] mx6cuboxi: Fix Ethernet PHY detection problem
2015-05-04 14:22 [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem Fabio Estevam
` (2 preceding siblings ...)
2015-05-04 14:55 ` Tom Rini
@ 2015-05-04 16:02 ` Vagrant Cascadian
2015-05-04 16:09 ` [U-Boot] [PATCH v2 " Stefano Babic
4 siblings, 0 replies; 10+ messages in thread
From: Vagrant Cascadian @ 2015-05-04 16:02 UTC (permalink / raw)
To: u-boot
On 2015-05-04, Fabio Estevam wrote:
> mx6cuboxi sometimes fails to recognize the Ethernet PHY:
>
> Net: Phy 0 not found
>
> The explanation for this behavior comes from from Rabeeh Khoury:
>
> "The LED_ACT pin on the carrier-one boards had a pull down that
> forces the phy address to 0x0; where on CuBox-i and the production
> HummingBoard that pin is connected directly to LED that depending
> on the pull down strength of the LED it might be sampled as '0' or '1' thus
> the phy address might appear as either address 0x0 or 0x4."
>
> "This is AR8035 implementation; in reset stage the LED pin is configured as
> input, and pull up/down does matter. In this case it configures the PHY
> address.
>
> After reset is deasserted the same LED pin becomes output and then
> according to the previous pull/up it should be active high/low"
>
> One way to properly fix this behavior is to place external pull-up/down
> resistors in the LED line, but from a software standpoint we can fix it
> by telling phy_find_by_mask() to scan the PHY at addresses
> 0x0 and 0x4.
>
> Reported-by: Vagrant Cascadian <vagrant@aikidev.net>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Explain what the proper hardware fix would be as suggested by Nikolay
> - Remove error message from fec_probe as this function already prints on error.
>
> board/solidrun/mx6cuboxi/mx6cuboxi.c | 29 ++++++++++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> index 9aa0259..e83d2fe 100644
> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> @@ -25,6 +25,7 @@
> #include <asm/imx-common/video.h>
> #include <mmc.h>
> #include <fsl_esdhc.h>
> +#include <malloc.h>
> #include <miiphy.h>
> #include <netdev.h>
> #include <asm/arch/crm_regs.h>
> @@ -152,9 +153,14 @@ int board_phy_config(struct phy_device *phydev)
> return 0;
> }
>
> +/* On Cuboxi Ethernet PHY can be located at addresses 0x0 or 0x4 */
> +#define ETH_PHY_MASK ((1 << 0x0) | (1 << 0x4))
> +
> int board_eth_init(bd_t *bis)
> {
> struct iomuxc *const iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR;
> + struct mii_dev *bus;
> + struct phy_device *phydev;
>
> int ret = enable_fec_anatop_clock(ENET_25MHZ);
> if (ret)
> @@ -165,7 +171,28 @@ int board_eth_init(bd_t *bis)
>
> setup_iomux_enet();
>
> - return cpu_eth_init(bis);
> + bus = fec_get_miibus(IMX_FEC_BASE, -1);
> + if (!bus)
> + return -EINVAL;
> +
> + phydev = phy_find_by_mask(bus, ETH_PHY_MASK, PHY_INTERFACE_MODE_RGMII);
> + if (!phydev) {
> + ret = -EINVAL;
> + goto free_bus;
> + }
> +
> + debug("using phy at address %d\n", phydev->addr);
> + ret = fec_probe(bis, -1, IMX_FEC_BASE, bus, phydev);
> + if (ret)
> + goto free_phydev;
> +
> + return 0;
> +
> +free_phydev:
> + free(phydev);
> +free_bus:
> + free(bus);
> + return ret;
> }
>
> #ifdef CONFIG_VIDEO_IPUV3
> --
> 1.9.1
Tested on cubox-i4pro and hummingboard-i2ex.
Tested-By: Vagrant Cascadian <vagrant@aikidev.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150504/febe8241/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread* [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem
2015-05-04 14:22 [U-Boot] [PATCH v2 1/2] mx6cuboxi: Fix Ethernet PHY detection problem Fabio Estevam
` (3 preceding siblings ...)
2015-05-04 16:02 ` [U-Boot] [U-Boot, v2, " Vagrant Cascadian
@ 2015-05-04 16:09 ` Stefano Babic
4 siblings, 0 replies; 10+ messages in thread
From: Stefano Babic @ 2015-05-04 16:09 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 04/05/2015 16:22, Fabio Estevam wrote:
> mx6cuboxi sometimes fails to recognize the Ethernet PHY:
>
> Net: Phy 0 not found
>
> The explanation for this behavior comes from from Rabeeh Khoury:
>
> "The LED_ACT pin on the carrier-one boards had a pull down that
> forces the phy address to 0x0; where on CuBox-i and the production
> HummingBoard that pin is connected directly to LED that depending
> on the pull down strength of the LED it might be sampled as '0' or '1' thus
> the phy address might appear as either address 0x0 or 0x4."
>
> "This is AR8035 implementation; in reset stage the LED pin is configured as
> input, and pull up/down does matter. In this case it configures the PHY
> address.
>
> After reset is deasserted the same LED pin becomes output and then
> according to the previous pull/up it should be active high/low"
>
> One way to properly fix this behavior is to place external pull-up/down
> resistors in the LED line, but from a software standpoint we can fix it
> by telling phy_find_by_mask() to scan the PHY at addresses
> 0x0 and 0x4.
>
> Reported-by: Vagrant Cascadian <vagrant@aikidev.net>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread