From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/4] Kconfig: Enable usage of escape char '\' in string values
Date: Thu, 07 May 2015 14:46:28 +0200 [thread overview]
Message-ID: <554B5EA4.3090502@denx.de> (raw)
In-Reply-To: <CAK7LNASi2N9g5gu6_LgAGNvWX_+D5Ppgk1ce1LN_SQeJ2WHCEw@mail.gmail.com>
Hi Masahiro,
On 07.05.2015 14:41, Masahiro Yamada wrote:
> 2015-05-07 21:13 GMT+09:00 Stefan Roese <sr@denx.de>:
>> I might have missed something, but I failed to use the escape char '\'
>> in strings. To pass a printf format string like "foo %d bar\n" via
>> Kconfig to the code.
>>
>> Right now its not possible to use the escape character '\' in Kconfig
>> string values correctly to e.g. set this string value "test output\n".
>> The '\n' will be converted to 'n'.
>>
>> The current implementation removes some of the '\' chars from the input
>> string in conf_set_sym_val(). Examples:
>>
>> '\' -> ''
>> '\\' -> '\'
>> '\\\' -> '\'
>> '\\\\' -> '\\'
>> ...
>>
>> And then doubles the backslash chars in the output string in
>> sym_escape_string_value(). Example:
>>
>> '\' -> '' -> ''
>> '\\' -> '\' -> '\\'
>> '\\\' -> '\' -> '\\'
>> '\\\\' -> '\\' -> '\\\\'
>> ...
>>
>> As you see in these examples, its impossible to generate a single '\'
>> charater in the output string as its needed for something like '\n'.
>>
>> This patch now changes this behavior to not drop some backslashes in
>> conf_set_sym_val() and to not add new backslashes in the resulting
>> output string. Removing the function sym_escape_string_value()
>> completely as its not needed anymore.
>
>
> Interesting.
> I did not know this behavior of strings in Kconfig.
Then I'm not the only one. ;)
> I want to see the reaction from linux-kconfig ML.
Okay. It makes sense then to send this patch to this list right away. A
quick search didn't reveal any results though. Where is this list hosted?
Thanks,
Stefan
next prev parent reply other threads:[~2015-05-07 12:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 12:13 [U-Boot] [PATCH v1 0/4] Add SHA256 encrypted stop string for autobooting Stefan Roese
2015-05-07 12:13 ` [U-Boot] [PATCH v1 1/4] Kconfig: Enable usage of escape char '\' in string values Stefan Roese
2015-05-07 12:41 ` Masahiro Yamada
2015-05-07 12:46 ` Stefan Roese [this message]
2015-05-07 12:53 ` Masahiro Yamada
2015-05-10 14:48 ` Simon Glass
2015-05-11 7:58 ` Stefan Roese
2015-05-11 13:27 ` Stefan Roese
2015-05-11 22:41 ` Simon Glass
2015-05-13 1:34 ` Masahiro Yamada
2015-05-15 7:13 ` Stefan Roese
2015-05-15 7:49 ` Masahiro Yamada
2015-05-07 12:13 ` [U-Boot] [PATCH v1 2/4] autoboot.c: Remove CONFIG_AUTOBOOT_STOP_STR2 and CONFIG_AUTOBOOT_DELAY_STR2 Stefan Roese
2015-05-07 23:47 ` Simon Glass
2015-05-11 12:38 ` Tom Rini
2015-05-07 12:13 ` [U-Boot] [PATCH v1 3/4] autoboot.c: Move config options to Kconfig Stefan Roese
2015-05-07 23:51 ` Simon Glass
2015-05-08 3:30 ` Masahiro Yamada
2015-05-08 6:00 ` Stefan Roese
2015-05-08 5:55 ` Stefan Roese
2015-05-10 14:49 ` Simon Glass
2015-05-07 12:13 ` [U-Boot] [PATCH v1 4/4] autoboot.c: Add feature to stop autobooting via SHA256 encrypted password Stefan Roese
2015-05-07 20:56 ` Magnus Lilja
2015-05-08 7:52 ` [U-Boot] [PATCH v2 " Stefan Roese
2015-05-10 14:49 ` Simon Glass
2015-05-11 7:16 ` Andreas Bießmann
2015-05-11 7:44 ` Stefan Roese
2015-05-15 7:44 ` Magnus Lilja
2015-05-15 8:44 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B5EA4.3090502@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox