public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4]: imx: mx6: use OTP for temperature grade and freq grade
Date: Thu, 07 May 2015 18:01:50 +0200	[thread overview]
Message-ID: <554B8C6E.5060600@denx.de> (raw)
In-Reply-To: <CAJ+vNU1-L0SfYCWrbpk+X4y8VpKA9C+qYHZyq5PVM3aiKmAKEA@mail.gmail.com>

On 07.05.2015 17:55, Tim Harvey wrote:
> On Tue, Apr 28, 2015 at 10:31 AM, Tim Harvey <tharvey@gateworks.com> wrote:
>> On Tue, Apr 28, 2015 at 10:11 AM, Stefan Roese <sr@denx.de> wrote:
>>> Hi Tim,
>>>
>>> On 28.04.2015 17:44, Tim Harvey wrote:
>>>>
>>>> The MX6 has OTP bits specifying the processor speed grade as well as
>>>> temperature grade.
>>>>
>>>> This series adds functions to return this information as well as adds the
>>>> details to the CPU info displayed.
>>>>
>>>> Additionally we use the temperature grade to replace the hard-coded limits
>>>> in imx_thermal.c
>>>>
>>>> I expect some possible discussion/debate regarding the displaying of this
>>>> info,
>>>> but perhaps adding the functions to obtain the info and use it for
>>>> imx_thermal
>>>> is beyond debate. Please let me know.
>>>
>>>
>>> Could you please send (or include in the commit text) an example, how these
>>> infos are displayed now in the bootup log? Best in comparison to the "old"
>>> log. To see the output change resulting from the patchset.
>>>
>>> Thanks,
>>> Stefan
>>>
>>
>> Stefan,
>>
>> Good point - as I am guessing there will be debate about the 'amount'
>> of info displayed and am open to suggestions on how to word it and/or
>> how to enable it. In future revs of the patchset I'll be more explicit
>> in the commit logs, but for now with the series applied I get this:
>>
>> IMX6Q automotive (1GHz capable) powering up at 800MHz:
>> - before:
>> CPU:   Freescale i.MX6Q rev1.2 at 792 MHz
>> - after Patch 1/4:
>> CPU:   Freescale i.MX6Q rev1.2 996 MHz (at 792 MHz)
>> - after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
>> CPU:   Freescale i.MX6Q rev1.2 automotive (-40C to 125C) 996 MHz (at 792 MHz)
>>
>> IMX6S industrial (800MHz capable) powering up at 800MHz:
>> - before:
>> CPU:   Freescale i.MX6SOLO rev1.2 at 792 MHz
>> - after Patch 1/4: (max speed == cur speed)
>> CPU:   Freescale i.MX6SOLO rev1.2 792 MHz
>> - after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
>> CPU:   Freescale i.MX6SOLO rev1.2 industrial (-40C to 105C) 792 MHz
>>
>> When I submit the next version I will split out adding the functions
>> to get speed-grade and temperature-grade from using those functions in
>> cpu_printinfo() as well as some may not be happy with adding more info
>> to cpu_printinfo() but may find value in setting the thermal limits of
>> imx_thermal properly based on temp-grade (Patch 4/4).
>>
>> Tim
>
> Stefano,
>
> I've cc'd all the maintainers I could find of MX6 based boards for
> comment on adding this text to the mx6 print_cpuinfo. I would like to
> see some ack/review from them otherwise I would think silence is
> considered a thumbs up ;)

Yep. ;)

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2015-05-07 16:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 15:44 [U-Boot] [PATCH 0/4]: imx: mx6: use OTP for temperature grade and freq grade Tim Harvey
2015-04-28 15:44 ` [U-Boot] [PATCH 1/4] imx: mx6: display max cpu frequency in print_cpuinfo() Tim Harvey
2015-04-29  8:08   ` Markus Niebel
2015-04-28 15:44 ` [U-Boot] [PATCH 2/4] mx6: add OTP bank1 registers Tim Harvey
2015-04-28 15:44 ` [U-Boot] [PATCH 3/4] imx: mx6: add display of temperature grade of processor in cpu_printinfo() Tim Harvey
2015-05-10 14:54   ` Fabio Estevam
2015-05-11 19:59     ` Tim Harvey
2015-05-11 20:04       ` Fabio Estevam
2015-04-28 15:44 ` [U-Boot] [PATCH 4/4] thermal: imx_thermal: use CPU temperature grade for trip points Tim Harvey
2015-04-28 17:11 ` [U-Boot] [PATCH 0/4]: imx: mx6: use OTP for temperature grade and freq grade Stefan Roese
2015-04-28 17:31   ` Tim Harvey
2015-05-07 15:55     ` Tim Harvey
2015-05-07 16:01       ` Stefan Roese [this message]
2015-05-07 16:07       ` Stefano Babic
2015-05-07 16:12       ` Christian Gmeiner
2015-05-08  6:57       ` Markus Niebel
2015-05-08 15:42         ` Tim Harvey
2015-05-08 17:35           ` Nikolay Dimitrov
2015-05-08 19:26             ` Tim Harvey
2015-05-10 13:46               ` Nikolay Dimitrov
2015-05-10 13:52                 ` Nikolay Dimitrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554B8C6E.5060600@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox