From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/16] usb: ohci: Remove unnecessary delays from hc_start and power power-on paths
Date: Sun, 10 May 2015 11:10:00 +0200 [thread overview]
Message-ID: <554F2068.2000102@redhat.com> (raw)
In-Reply-To: <201505060101.00835.marex@denx.de>
Hi,
On 06-05-15 01:01, Marek Vasut wrote:
> On Tuesday, May 05, 2015 at 11:56:16 PM, Hans de Goede wrote:
>> The common usb_hub code already waits a full second after powering up
>> ports, so there is no need for additional delays inside the hcd code.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> This makes a driver depend on the behavior of the subsystem, which might
> change though, right ? Won't this bite us in the future ?
Well since the usb spec says that we must wait a minimum amount of time
after port power on (exact time is in the hub descriptor) the subsys code
better not change otherwise we would be violating the spec in the future,
also note that we must not only do the wait for root ports but also
for external hub ports, so we can really never drop the wait from the
subsys code, and having a separate wait for just the root hub in the hcd
code will only lead to doing the waiting twice.
I'll change the commit message to make this clear.
Regards,
Hans
next prev parent reply other threads:[~2015-05-10 9:10 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 21:56 [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support Hans de Goede
2015-05-05 21:56 ` [U-Boot] [PATCH 01/16] usb: Fix maxpacketsize for first descriptor read for low-speed usb devs Hans de Goede
2015-05-05 22:54 ` Marek Vasut
2015-05-06 21:43 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 02/16] usb: Stop reset procedure when a dev is handed over to a companion hcd Hans de Goede
2015-05-05 22:54 ` Marek Vasut
2015-05-05 21:56 ` [U-Boot] [PATCH 03/16] usb: ohci: Remove unused devgone global variable Hans de Goede
2015-05-05 22:55 ` Marek Vasut
2015-05-06 21:43 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 04/16] usb: ohci: Pass around a pointer to ohci_t rather then accessing global vars Hans de Goede
2015-05-05 22:55 ` Marek Vasut
2015-05-06 21:43 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 05/16] usb: ohci: Move the ohci_dev struct to inside the main ohci struct Hans de Goede
2015-05-05 22:57 ` Marek Vasut
2015-05-06 21:43 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 06/16] usb: ohci: Move the td array struct to inside the ohci_dev struct Hans de Goede
2015-05-05 22:57 ` Marek Vasut
2015-05-06 21:44 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 07/16] usb: ohci: Remove unnecessary phcca variable Hans de Goede
2015-05-05 22:57 ` Marek Vasut
2015-05-06 21:44 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 08/16] usb: ohci: Move static func and var declarations from ohci.h to ohci-hcd.c Hans de Goede
2015-05-05 22:58 ` Marek Vasut
2015-05-06 21:44 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 09/16] usb: ohci: Fix ctrl in messages with a data-len of 0 Hans de Goede
2015-05-05 22:59 ` Marek Vasut
2015-05-05 23:25 ` Hans de Goede
2015-05-05 23:38 ` Marek Vasut
2015-05-06 21:44 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 10/16] usb: ohci: Add proper cache flushing / invalidating for non cache coherent cpus Hans de Goede
2015-05-05 23:02 ` Marek Vasut
2015-05-06 21:44 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 11/16] usb: ohci: Don't log an error on interrupt packet timeout Hans de Goede
2015-05-05 22:59 ` Marek Vasut
2015-05-06 21:44 ` Simon Glass
2015-05-05 21:56 ` [U-Boot] [PATCH 12/16] usb: ohci: Do not resubmit and leak urbs for interrupt packets Hans de Goede
2015-05-05 23:00 ` Marek Vasut
2015-05-05 21:56 ` [U-Boot] [PATCH 13/16] usb: ohci: Remove unnecessary delays from hc_start and power power-on paths Hans de Goede
2015-05-05 23:01 ` Marek Vasut
2015-05-10 9:10 ` Hans de Goede [this message]
2015-05-10 9:49 ` Marek Vasut
2015-05-05 21:56 ` [U-Boot] [PATCH 14/16] usb: ohci: Skip unnecessary mdelay(1) calls in various places Hans de Goede
2015-05-05 23:01 ` Marek Vasut
2015-05-05 21:56 ` [U-Boot] [PATCH 15/16] usb: ohci: Add dm support Hans de Goede
2015-05-05 23:04 ` Marek Vasut
2015-05-05 21:56 ` [U-Boot] [PATCH 16/16] sunxi: ohci: Add ohci usb host controller support Hans de Goede
2015-05-05 23:03 ` Marek Vasut
2015-05-09 13:56 ` Ian Campbell
2015-05-05 22:23 ` [U-Boot] [PATCH 00/16] usb core fixes + ohci fixes + ohci dm support Marek Vasut
2015-05-05 22:24 ` Simon Glass
2015-05-05 22:50 ` Hans de Goede
2015-05-05 22:52 ` Marek Vasut
2015-05-05 22:53 ` Simon Glass
2015-05-05 23:03 ` Marek Vasut
2015-05-05 22:52 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554F2068.2000102@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox