[U-Boot] [PATCH v1 3/4] autoboot.c: Move config options to Kconfig

Simon Glass
2015-05-10T14:49:03Z

On 7 May 2015 at 23:55, Stefan Roese <sr@denx.de> wrote:
> Hi Simon,
>
> On 08.05.2015 01:51, Simon Glass wrote:
>>
>> On 7 May 2015 at 06:13, Stefan Roese <sr@denx.de> wrote:
>>>
>>> This patch moves the following config options to Kconfig:
>>>
>>> CONFIG_AUTOBOOT_KEYED
>>> CONFIG_AUTOBOOT_PROMPT
>>> CONFIG_AUTOBOOT_DELAY_STR
>>> CONFIG_AUTOBOOT_STOP_STR
>>> AUTOBOOT_KEYED_CTRLC
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> ---
>>>
>
> <snip>
>
>
>>> diff --git a/common/Kconfig b/common/Kconfig
>>> index 15759f7..ff150f0 100644
>>> --- a/common/Kconfig
>>> +++ b/common/Kconfig
>>> @@ -17,6 +17,70 @@ config SYS_HUSH_PARSER
>>> help
>>> Backward compatibility.
>>>
>>> +menu "Autoboot options"
>>> +
>>> +config AUTOBOOT_KEYED
>>> + bool "Stop autobooting via specific input key / string"
>>> + default n
>>> + help
>>> + This option enables stopping (aborting) of the automatic
>>> + boot feature only by issuing a specific input key or
>>> + string. If not enabled, any input key will abort the
>>> + U-Boot automatic booting process and bring the device
>>> + to the U-Boot prompt for user input.
>>> +
>>> +config AUTOBOOT_PROMPT
>>> + string "Autoboot stop prompt"
>>> + depends on AUTOBOOT_KEYED
>>> + default "Autoboot in %d seconds\n"
>>
>>
>> Doesn't this mean that the autoboot message will always be printed? I
>> wonder if we need a separate 'AUTOBOOT' to enable the feature?
>
>
> AUTOBOOT_PROMPT is enabled now via AUTOBOOT_KEYED. Most boards don't enable
> this option, so nothing is changed for those boards.

Thanks.

Reviewed-by: Simon Glass <sjg@chromium.org>