public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define to mx6_common.h
Date: Mon, 11 May 2015 15:44:18 +0200	[thread overview]
Message-ID: <5550B232.1030400@denx.de> (raw)
In-Reply-To: <CALeDE9NW68MhH72yYEaGSXRoLQ=wMF+Gjrp--izLtutJ9djg-A@mail.gmail.com>

Hi Peter,

On 11/05/2015 14:51, Peter Robinson wrote:

>> You're dropping CONFIG_CMD_GPIO (a handy thing IMHO) in a few cases and
>> not adding it in globally which I would argue is the right thing to do.
> 
> Bah, oversight! OK to add it back to mx6_common.h in a follow up patch?

What about to fix it (as the other Tom's comments) in this patchset ?
Could you send a V2 fixing them ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2015-05-11 13:44 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 11:23 [U-Boot] [PATCH 0/10] i.MX6: move duplicated options to mx6_common to standardise mx6 config Peter Robinson
2015-05-11 11:23 ` [U-Boot] [PATCH 01/10] novena: standardise mx6_common.h include Peter Robinson
2015-05-11 12:38   ` Tom Rini
2015-05-11 11:23 ` [U-Boot] [PATCH 02/10] imx6: move all standard includes to mx6_common.h Peter Robinson
2015-05-11 12:32   ` Tom Rini
2015-05-11 13:13     ` Peter Robinson
2015-05-11 13:20       ` Tom Rini
2015-05-11 13:25         ` Peter Robinson
2015-05-11 11:23 ` [U-Boot] [PATCH 03/10] imx6: move generic imx6 options " Peter Robinson
2015-05-11 12:43   ` Tom Rini
2015-05-12  6:29   ` Markus Niebel
2015-05-11 11:23 ` [U-Boot] [PATCH 04/10] imx6: move standard ATAG configs " Peter Robinson
2015-05-11 12:43   ` Tom Rini
2015-05-11 11:23 ` [U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define " Peter Robinson
2015-05-11 12:43   ` Tom Rini
2015-05-11 12:51     ` Peter Robinson
2015-05-11 13:21       ` Tom Rini
2015-05-11 13:44       ` Stefano Babic [this message]
2015-05-11 16:14         ` Peter Robinson
2015-05-11 11:23 ` [U-Boot] [PATCH 06/10] imx6: centralise common boot options in mx6_common.h Peter Robinson
2015-05-11 11:23 ` [U-Boot] [PATCH 07/10] imx6: move generic miscellaneous and overwrite options Peter Robinson
2015-05-11 12:33   ` Tom Rini
2015-05-11 13:28     ` Peter Robinson
2015-05-11 11:23 ` [U-Boot] [PATCH 08/10] imx6: standardise filesystem and boot options to Peter Robinson
2015-05-11 12:25   ` Tom Rini
2015-05-11 12:52     ` Peter Robinson
2015-05-11 13:20       ` Tom Rini
2015-05-11 11:23 ` [U-Boot] [PATCH 09/10] imx6: generic MMC config options to mx6_common Peter Robinson
2015-05-11 12:43   ` Tom Rini
2015-05-11 11:23 ` [U-Boot] [PATCH 10/10] mx6: standardise CONFIG_CMD_CACHE Peter Robinson
2015-05-11 12:43   ` Tom Rini
2015-05-11 12:13 ` [U-Boot] [PATCH 0/10] i.MX6: move duplicated options to mx6_common to standardise mx6 config Fabio Estevam
2015-05-11 12:18 ` Stefano Babic
2015-05-11 12:43 ` Tom Rini
2015-05-11 14:40 ` Eric Nelson
  -- strict thread matches above, loose matches on Subject: below --
2015-05-11 16:22 [U-Boot] [PATCH 0/10 v2] " Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define to mx6_common.h Peter Robinson
2015-05-22 16:30 [U-Boot] [PATCH 0/10 v3] i.MX6: move duplicated options to mx6_common to standardise mx6 config Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define to mx6_common.h Peter Robinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5550B232.1030400@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox