From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Date: Mon, 11 May 2015 19:55:35 +0200 Subject: [U-Boot] [PATCH 08/10] imx6: standardise filesystem and boot options In-Reply-To: <5550E52D.6030809@web.de> References: <5550E52D.6030809@web.de> Message-ID: <5550ED17.9030207@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/11/15 19:21, Soeren Moch wrote: > [...] > > > diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h > > index 08ae39c..862f668 100644 > > --- a/include/configs/mx6_common.h > > +++ b/include/configs/mx6_common.h > > @@ -58,6 +58,18 @@ > > #define CONFIG_CONS_INDEX 1 > > #define CONFIG_BAUDRATE 115200 > > > > +/* Filesystems and image support */ > > +#define CONFIG_OF_LIBFDT > > +#define CONFIG_CMD_BOOTZ > > +#define CONFIG_SUPPORT_RAW_INITRD > > +#define CONFIG_CMD_FS_GENERIC > > +#define CONFIG_DOS_PARTITION > > +#define CONFIG_CMD_EXT2 > > +#define CONFIG_CMD_EXT4 > > +#define CONFIG_CMD_EXT4_WRITE > > +#define CONFIG_CMD_FAT > > + > > /* Miscellaneous configurable options */ > > #define CONFIG_SYS_NO_FLASH > > #undef CONFIG_CMD_IMLS > > [...] > > > diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h > > index 34e12eb..5ec2ba6 100644 > > --- a/include/configs/tbs2910.h > > +++ b/include/configs/tbs2910.h > > @@ -58,15 +58,6 @@ > > #define CONFIG_CMD_TIME > > > > /* Filesystems / image support */ > > -#define CONFIG_CMD_EXT4 > > -#define CONFIG_CMD_FAT > > -#define CONFIG_DOS_PARTITION > > -#define CONFIG_EFI_PARTITION > > -#define CONFIG_CMD_FS_GENERIC > > - > > -#define CONFIG_OF_LIBFDT > > -#define CONFIG_CMD_BOOTZ > > -#define CONFIG_SUPPORT_RAW_INITRD > > #define CONFIG_FIT > > > > Peter, > > you removed CONFIG_EFI_PARTITION from tbs2910.h without adding it to mx6_common.h . > Please fix this in your next version of the patch series. > > Thanks, > Soeren > One additional comment: Do we really need CONFIG_CMD_EXT2 when CONFIG_CMD_EXT4 is defined? My understanding was so far, that CONFIG_CMD_EXT4 alone is enough. Regards, Soeren