From: Markus Niebel <list-09@tqsc.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h
Date: Tue, 12 May 2015 10:40:25 +0200 [thread overview]
Message-ID: <5551BC79.1030107@tqsc.de> (raw)
In-Reply-To: <1431361332-24997-4-git-send-email-pbrobinson@gmail.com>
Hello Peter,
sorry for the noise, did not see v2 of your series. Just one thing:
Am 11.05.2015 um 18:22 schrieb Peter Robinson:
> All boards define CONFIG_MX6, CONFIG_DISPLAY_BOARDINFO, CONFIG_DISPLAY_CPUINFO
> and CONFIG_SYS_GENERIC_BOARD so define them in mx6_common
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
[...]
>
> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
> index 85bf039..fc19fbb 100644
> --- a/include/configs/mx6_common.h
> +++ b/include/configs/mx6_common.h
> @@ -38,4 +38,9 @@
> #include <asm/imx-common/gpio.h>
> #include <config_cmd_default.h>
>
> +#define CONFIG_MX6
Here we need an #if !defined(CONFIG_MX6) because secomx6quq7
(and soon hopefully other boards) sets this via Kconfig under
arch/arm/cpu/armv7/mx6
[...]
Regards
Markus
next prev parent reply other threads:[~2015-05-12 8:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 16:22 [U-Boot] [PATCH 0/10 v2] i.MX6: move duplicated options to mx6_common to standardise mx6 config Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 01/10] novena: standardise mx6_common.h include Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 02/10] imx6: move all standard includes to mx6_common.h Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 03/10] imx6: move generic imx6 options " Peter Robinson
2015-05-12 8:40 ` Markus Niebel [this message]
2015-05-12 10:51 ` Tom Rini
2015-05-12 11:12 ` Markus Niebel
2015-05-15 11:30 ` Stefano Babic
2015-05-11 16:22 ` [U-Boot] [PATCH 04/10] imx6: move standard ATAG configs " Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define " Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 06/10] imx6: centralise common boot options in mx6_common.h Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 07/10] [PATCH 07/10] imx6: move generic miscellaneous and overwrite options Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 08/10] imx6: standardise filesystem and boot options Peter Robinson
2015-05-11 17:21 ` Soeren Moch
2015-05-11 17:55 ` Soeren Moch
2015-05-11 16:22 ` [U-Boot] [PATCH 09/10] imx6: generic MMC config options to mx6_common Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 10/10] mx6: standardise CONFIG_CMD_CACHE Peter Robinson
2015-05-11 18:43 ` [U-Boot] [PATCH 0/10 v2] i.MX6: move duplicated options to mx6_common to standardise mx6 config Soeren Moch
2015-05-15 9:35 ` Stefano Babic
2015-05-15 13:11 ` Soeren Moch
2015-05-19 12:53 ` Stefano Babic
2015-05-21 23:15 ` Peter Robinson
2015-05-22 7:44 ` Stefano Babic
-- strict thread matches above, loose matches on Subject: below --
2015-05-22 16:30 [U-Boot] [PATCH 0/10 v3] " Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h Peter Robinson
2015-05-22 18:18 ` Soeren Moch
2015-05-26 11:39 ` Stefano Babic
2015-05-26 12:10 ` Soeren Moch
2015-05-29 18:02 ` Soeren Moch
2015-05-11 11:23 [U-Boot] [PATCH 0/10] i.MX6: move duplicated options to mx6_common to standardise mx6 config Peter Robinson
2015-05-11 11:23 ` [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h Peter Robinson
2015-05-11 12:43 ` Tom Rini
2015-05-12 6:29 ` Markus Niebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5551BC79.1030107@tqsc.de \
--to=list-09@tqsc.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox