From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Niebel <list-09@tqsc.de>
Date: Tue, 12 May 2015 10:40:25 +0200
Subject: [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to
	mx6_common.h
In-Reply-To: <1431361332-24997-4-git-send-email-pbrobinson@gmail.com>
References: <1431361332-24997-1-git-send-email-pbrobinson@gmail.com>
 <1431361332-24997-4-git-send-email-pbrobinson@gmail.com>
Message-ID: <5551BC79.1030107@tqsc.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Peter,

sorry for the noise, did not see v2 of your series. Just one thing:

Am 11.05.2015 um 18:22 schrieb Peter Robinson:
> All boards define CONFIG_MX6, CONFIG_DISPLAY_BOARDINFO, CONFIG_DISPLAY_CPUINFO
> and CONFIG_SYS_GENERIC_BOARD so define them in mx6_common
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

[...] 

>  
> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
> index 85bf039..fc19fbb 100644
> --- a/include/configs/mx6_common.h
> +++ b/include/configs/mx6_common.h
> @@ -38,4 +38,9 @@
>  #include <asm/imx-common/gpio.h>
>  #include <config_cmd_default.h>
>  
> +#define CONFIG_MX6

Here we need an #if !defined(CONFIG_MX6) because secomx6quq7
(and soon hopefully other boards) sets this via Kconfig under
arch/arm/cpu/armv7/mx6

[...]

Regards

Markus