[U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h

From: Markus Niebel <list-09@tqsc.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h
Date: Tue, 12 May 2015 13:12:10 +0200	[thread overview]
Message-ID: <5551E00A.1020400@tqsc.de> (raw)
In-Reply-To: <20150512105135.GZ5267@bill-the-cat>

Hello

Am 12.05.2015 um 12:51 schrieb Tom Rini:
> On Tue, May 12, 2015 at 10:40:25AM +0200, Markus Niebel wrote:
> 
>> Hello Peter,
>>
>> sorry for the noise, did not see v2 of your series. Just one thing:
>>
>> Am 11.05.2015 um 18:22 schrieb Peter Robinson:
>>> All boards define CONFIG_MX6, CONFIG_DISPLAY_BOARDINFO, CONFIG_DISPLAY_CPUINFO
>>> and CONFIG_SYS_GENERIC_BOARD so define them in mx6_common
>>>
>>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>
>> [...] 
>>
>>>  
>>> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
>>> index 85bf039..fc19fbb 100644
>>> --- a/include/configs/mx6_common.h
>>> +++ b/include/configs/mx6_common.h
>>> @@ -38,4 +38,9 @@
>>>  #include <asm/imx-common/gpio.h>
>>>  #include <config_cmd_default.h>
>>>  
>>> +#define CONFIG_MX6
>>
>> Here we need an #if !defined(CONFIG_MX6) because secomx6quq7
>> (and soon hopefully other boards) sets this via Kconfig under
>> arch/arm/cpu/armv7/mx6
> 
> Oh good catch.  Would it be hard to just make everyone do this via
> Kconfig instead?  I would expect not...
> 

See the series for TQMa6 I posted. Main point is to delete inclusion
of the board Kconfig from arch/arm/Kconfig and to add them to
source them from arch/arm/cpu/armv7/mx6/Kconfig.

As a side effect the CPU type can then also be selected using Kconfig ...

> 
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 