[U-Boot] [PATCH v2 2/4] arm: mvebu: Update CBAR with SOC regs base

Stefan Roese
2015-05-15T07:01:16Z

On 14.05.2015 01:17, Kevin Smith wrote:
> SMP-enabled Linux kernels read the CBAR register in CP15 to find
> the address of the SCU registers. After remapping internal
> registers, also update the CBAR so the kernel can find them.

Thanks Kevin. Only some coding style related comments below:

> Signed-off-by: Kevin Smith <kevin.smith@elecsyscorp.com>
> ---
> arch/arm/mach-mvebu/cpu.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c
> index 417fc35..2970e07 100644
> --- a/arch/arm/mach-mvebu/cpu.c
> +++ b/arch/arm/mach-mvebu/cpu.c
> @@ -161,10 +161,17 @@ static void update_sdram_window_sizes(void)
> }
>
> #ifdef CONFIG_ARCH_CPU_INIT
> +static void set_cbar (u32 addr)
> +{
> + asm ("mcr p15, 4, %0, c15, c0" : : "r" (addr));
> +}

Indentation with tabs please. And no space before the "(".

> +
> +
> int arch_cpu_init(void)
> {
> /* Linux expects the internal registers to be at 0xf1000000 */
> writel(SOC_REGS_PHY_BASE, INTREG_BASE_ADDR_REG);
> + set_cbar (SOC_REGS_PHY_BASE + 0xC000);

No space before the "(" please. checkpatch should complain about these
minor issues btw. So its always recommended to run it before sending the
patches to the list.

Please send an updated version and add my

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan