public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] mxs: Possible in bug in mxs_enable_4p2_dcdc_input
Date: Fri, 15 May 2015 13:14:51 +0200	[thread overview]
Message-ID: <5555D52B.7040106@denx.de> (raw)
In-Reply-To: <978811302.20941.1431496941951.JavaMail.open-xchange@oxbsltgw06.schlund.de>

Hi Stefan,

On 13/05/2015 08:02, Stefan Wahren wrote:
> Hi,
> 
> during the study of DC-DC handling in u-boot i noticed a possible bug.
> 
> In case the DC-DC is already enabled the function returns without reenabling
> brown out detection. I don't think that's okay.
> A possible fix would be to do the check if DC-DC is already enabled before
> disabling brown out detection. This idea is
> attached as a draft. If it's acceptable i will send a proper patch.
> 

It looks like we agree on your changes. Can you send then a proper patch
with your Signed-off-by ?

Thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2015-05-15 11:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  6:02 [U-Boot] mxs: Possible in bug in mxs_enable_4p2_dcdc_input Stefan Wahren
2015-05-13  7:13 ` Marek Vasut
2015-05-13  8:14   ` Stefan Wahren
2015-05-13 20:03     ` Marek Vasut
2015-05-15 11:14 ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5555D52B.7040106@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox