From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 15 May 2015 13:14:51 +0200 Subject: [U-Boot] mxs: Possible in bug in mxs_enable_4p2_dcdc_input In-Reply-To: <978811302.20941.1431496941951.JavaMail.open-xchange@oxbsltgw06.schlund.de> References: <978811302.20941.1431496941951.JavaMail.open-xchange@oxbsltgw06.schlund.de> Message-ID: <5555D52B.7040106@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, On 13/05/2015 08:02, Stefan Wahren wrote: > Hi, > > during the study of DC-DC handling in u-boot i noticed a possible bug. > > In case the DC-DC is already enabled the function returns without reenabling > brown out detection. I don't think that's okay. > A possible fix would be to do the check if DC-DC is already enabled before > disabling brown out detection. This idea is > attached as a draft. If it's acceptable i will send a proper patch. > It looks like we agree on your changes. Can you send then a proper patch with your Signed-off-by ? Thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================