From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 15 May 2015 13:30:42 +0200 Subject: [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h In-Reply-To: <20150512105135.GZ5267@bill-the-cat> References: <1431361332-24997-1-git-send-email-pbrobinson@gmail.com> <1431361332-24997-4-git-send-email-pbrobinson@gmail.com> <5551BC79.1030107@tqsc.de> <20150512105135.GZ5267@bill-the-cat> Message-ID: <5555D8E2.9030403@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peter, On 12/05/2015 12:51, Tom Rini wrote: > On Tue, May 12, 2015 at 10:40:25AM +0200, Markus Niebel wrote: > >> Hello Peter, >> >> sorry for the noise, did not see v2 of your series. Just one thing: >> >> Am 11.05.2015 um 18:22 schrieb Peter Robinson: >>> All boards define CONFIG_MX6, CONFIG_DISPLAY_BOARDINFO, CONFIG_DISPLAY_CPUINFO >>> and CONFIG_SYS_GENERIC_BOARD so define them in mx6_common >>> >>> Signed-off-by: Peter Robinson >>> Reviewed-by: Tom Rini >> >> [...] >> >>> >>> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h >>> index 85bf039..fc19fbb 100644 >>> --- a/include/configs/mx6_common.h >>> +++ b/include/configs/mx6_common.h >>> @@ -38,4 +38,9 @@ >>> #include >>> #include >>> >>> +#define CONFIG_MX6 >> >> Here we need an #if !defined(CONFIG_MX6) because secomx6quq7 >> (and soon hopefully other boards) sets this via Kconfig under >> arch/arm/cpu/armv7/mx6 > > Oh good catch. Would it be hard to just make everyone do this via > Kconfig instead? I would expect not... > What do you mind about this ? Can you fix it directly in a V3 ? Thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================