From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 15 May 2015 15:24:50 +0200 Subject: [U-Boot] [PATCH v2 3/4] imx: mx6: add display of CPU temperature grade in print_cpuinfo() In-Reply-To: References: <1431580312-24880-1-git-send-email-tharvey@gateworks.com> <1431580312-24880-4-git-send-email-tharvey@gateworks.com> Message-ID: <5555F3A2.9090906@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tim, On 15/05/2015 15:16, Tim Harvey wrote: > On Fri, May 15, 2015 at 1:14 AM, Christian Gmeiner > wrote: >> 2015-05-14 7:11 GMT+02:00 Tim Harvey : >>> When CONFIG_IMX6_THERMAL is defined print the CPU temperature grade info >>> along with the current temperature. >>> >>> Before: >>> CPU: Temperature 42 C >>> >>> After: >>> CPU: Automotive temperature grade (-40C to 125C) at 42C >>> CPU: Industiral temperature grade (-40C to 105C) at 42C >>> CPU: Extended Commercial temperature grade (-20C to 105C) at 42C >>> >>> Signed-off-by: Tim Harvey >>> --- >>> v2: >>> - moved display of CPU temperature grade to own patch and combined with the >>> current temperature from the thermal sensor driver >>> - add example output to description >>> >>> Signed-off-by: Tim Harvey >>> --- >>> arch/arm/imx-common/cpu.c | 27 +++++++++++++++++++++++---- >>> 1 file changed, 23 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c >>> index 6b20482..f1b49bb 100644 >>> --- a/arch/arm/imx-common/cpu.c >>> +++ b/arch/arm/imx-common/cpu.c >>> @@ -16,6 +16,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -146,7 +147,7 @@ int print_cpuinfo(void) >>> >>> #if defined(CONFIG_MX6) && defined(CONFIG_IMX6_THERMAL) >>> struct udevice *thermal_dev; >>> - int cpu_tmp, ret; >>> + int cpu_tmp, minc, maxc, ret; >>> #endif >>> >>> cpurev = get_cpu_rev(); >>> @@ -172,16 +173,34 @@ int print_cpuinfo(void) >>> #endif >>> >>> #if defined(CONFIG_MX6) && defined(CONFIG_IMX6_THERMAL) >>> + puts("CPU: "); >>> + if (!is_cpu_type(MXC_CPU_MX6SX)) { >>> + switch (get_cpu_temp_grade(&minc, &maxc)) { >>> + case TEMP_AUTOMOTIVE: >>> + puts("Automotive temperature grade "); >>> + break; >>> + case TEMP_INDUSTRIAL: >>> + puts("Industrial temperature grade "); >>> + break; >>> + case TEMP_EXTCOMMERCIAL: >>> + puts("Extended Commercial temperature grade "); >>> + break; >>> + default: >>> + puts("Commercial temperature grade "); >>> + break; >>> + } >>> + printf("(%dC to %dC)", minc, maxc); >>> + } >> >> For the additions above we do not need CONFIG_IMX6_THERMAL. > > Hi Christian, > > Thanks for the review. > > Its true that CONFIG_IMX6_THERMAL is not needed for cpu temperature > grade but I felt that there would be resistance in general to adding > additional lines in print_cpuinfo without allowing them to be easily > disabled. Agree on this point. > I felt that temperature grade and current temperature made > sense to go together in this fasion. > > Looking over this though did remind me that now that Freescale has > told me that the IMX6SX has the same OTP registers/definitions for > temperature grade programmed I can remove the skip for MX6SX. I would > however sure like to have someone with an actual MX6SX enable that > code and give us some testing feedback. > Right. My proposal is to merge the currrent patchset, enabling for IMX6SX again when someone will test it. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================