public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] imx: mx6: add display of CPU temperature grade in print_cpuinfo()
Date: Fri, 15 May 2015 15:44:50 +0200	[thread overview]
Message-ID: <5555F852.5040302@denx.de> (raw)
In-Reply-To: <CAJ+vNU3c-c2yr4kxBsKx3N7z=uCyEBDGHzj=8C0xvU7Ji8TE1A@mail.gmail.com>

Hi Tim,

On 15/05/2015 15:31, Tim Harvey wrote:

>> Right. My proposal is to merge the currrent patchset, enabling for
>> IMX6SX again when someone will test it.
>>
>> Best regards,
>> Stefano Babic
>>
> 
> Stefano,
> 
> Yes, that sounds like the best approach. What were your thoughts on
> enabling the second CPU: line just to display the temperature grade if
> CONFIG_IMX6_THERMAL was not enabled?

As you said, printing a lot can be disturbing for someone, and letting
the possibility to turn out prints is not bad. I will let the board
maintainer to decide it.

> 
> I'm surprised someone on this list hasn't already tested this on IMX6SX.
> 

I am quite convinced that patches are tested by a few until they are
merged. If there is a ready-to-use tree, people are more motivated to
test it.

> Fabio - certainly you must have a reference board with an IMX6SX and
> could enable/test that the CPU markings agree with what is
> detected/displayed via OTP?
> 

Of course, I could delay for applying this patchset if Fabio / someone
has the possibility to test it with 6X. Anyway, running on 6X is
protected by the check on the cpu, and I do not see problems to merge it.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2015-05-15 13:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14  5:11 [U-Boot] [PATCH v2 0/4]: imx: mx6: use OTP for temperature grade info Tim Harvey
2015-05-14  5:11 ` [U-Boot] [PATCH v2 1/4] mx6: add OTP bank1 registers Tim Harvey
2015-05-15  8:08   ` Christian Gmeiner
2015-05-17 22:32   ` Nikolay Dimitrov
2015-05-14  5:11 ` [U-Boot] [PATCH v2 2/4] imx: mx6: add get_cpu_temp_grade to obtain cpu temperature grade from OTP Tim Harvey
2015-05-15  8:17   ` Christian Gmeiner
2015-05-17 22:33   ` Nikolay Dimitrov
2015-05-14  5:11 ` [U-Boot] [PATCH v2 3/4] imx: mx6: add display of CPU temperature grade in print_cpuinfo() Tim Harvey
2015-05-15  8:14   ` Christian Gmeiner
2015-05-15 13:16     ` Tim Harvey
2015-05-15 13:24       ` Stefano Babic
2015-05-15 13:31         ` Tim Harvey
2015-05-15 13:36           ` Fabio Estevam
2015-05-18  0:11             ` Peng Fan
2015-05-18 13:30               ` Tim Harvey
2015-05-15 13:44           ` Stefano Babic [this message]
2015-05-17 22:33   ` Nikolay Dimitrov
2015-05-14  5:11 ` [U-Boot] [PATCH v2 4/4] thermal: imx_thermal: use CPU temperature grade for trip points Tim Harvey
2015-05-17 22:34   ` Nikolay Dimitrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5555F852.5040302@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox