From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 08/19] imx: ventana: config: use MMC SPL RAW support
Date: Fri, 15 May 2015 16:20:12 +0200 [thread overview]
Message-ID: <5556009C.80707@denx.de> (raw)
In-Reply-To: <CAJ+vNU1cjGmUNFd-9k3vizLgjMRqNLaux_CB+seeMcDwuPmXHw@mail.gmail.com>
Hi Tim,
On 13/05/2015 01:23, Tim Harvey wrote:
> On Fri, May 8, 2015 at 6:36 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> Hi Tim,
>>
>> On Fri, May 8, 2015 at 10:28 PM, Tim Harvey <tharvey@gateworks.com> wrote:
>>> Switch to MMC RAW support for SPL. We will place the uboot.img at 69KB.
>>>
>>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>>> ---
>>> include/configs/gw_ventana.h | 6 ++----
>>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
>>> index 63af20c..e18e262 100644
>>> --- a/include/configs/gw_ventana.h
>>> +++ b/include/configs/gw_ventana.h
>>> @@ -11,10 +11,8 @@
>>> #define CONFIG_SPL_BOARD_INIT
>>> #define CONFIG_SPL_NAND_SUPPORT
>>> #define CONFIG_SPL_MMC_SUPPORT
>>> -#define CONFIG_SPL_FAT_SUPPORT
>>> -/*
>>> -#define CONFIG_SPL_SATA_SUPPORT
>>> -*/
>>> +/* Location on MMC to read U-Boot from */
>>> +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 138 /* 69KB */
>>
>> No need to define this as it is the default from imx6_spl.h
>
> Fabio,
>
> Thanks for pointing that out - I'll remove it.
>
Then rework the commit message, pointing to the remove of SPL_FAT and
SPL_SATA.
I like that your patchset is fully orthogonal - rewieving is easier and
I do not miss your changes - thanks for that !
For that reason, I am applying most of your patches - you do not need to
post the whole patchset again. Due to rework in this one, I would like
you repost in a new patchset only these ones:
imx: ventana: config: use MMC SPL RAW support (this one)
imx: ventana: (cosmetic) clean up size defines for improved readability
imx: ventana: add pmic_setup to SPL
imx: ventana: config: enable Falcon mode
I am merging the rest of your patches
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2015-05-15 14:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 1:28 [U-Boot] [PATCH 00/19] imx: ventana: misc updates Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 01/19] imx: ventana: set dtype env var to boot media Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 02/19] imx: ventana: display SPL boot device Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 03/19] imx: ventana: config: enable gpio command Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 04/19] imx: ventana: config: enable driver model Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 05/19] imx: ventana: register gpio's with gpio_request Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 06/19] imx: ventana: enable DM_SERIAL Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 07/19] imx: ventana: config: enable Thermal support Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 08/19] imx: ventana: config: use MMC SPL RAW support Tim Harvey
2015-05-09 1:36 ` Fabio Estevam
2015-05-12 23:23 ` Tim Harvey
2015-05-15 14:20 ` Stefano Babic [this message]
2015-05-09 1:28 ` [U-Boot] [PATCH 09/19] imx: ventana: (cosmetic) clean up size defines for improved readability Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 10/19] imx: ventana: fix pcie reset for GW522x Tim Harvey
2015-05-11 7:59 ` Stefano Babic
2015-05-11 19:12 ` Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 11/19] imx: ventana: default msata/pci mux to pci before PCI enumeration Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 12/19] imx: ventana: split out common functions between SPL and uboot Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 13/19] imx: ventana: move GSC boot watchdog disable function to gsc.c Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 14/19] imx: ventana: detect pmic using i2c probe instead of board model Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 15/19] imx: ventana: use common uart and i2c setup functions in SPL Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 16/19] imx: ventana: add gpio setup to SPL Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 17/19] imx: ventana: add pmic_setup " Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 18/19] imx: ventana: add GSC boot watchdog disable " Tim Harvey
2015-05-09 1:28 ` [U-Boot] [PATCH 19/19] imx: ventana: config: enable Falcon mode Tim Harvey
2015-05-18 23:25 ` Fabio Estevam
2015-05-19 13:26 ` Tim Harvey
2015-05-19 13:30 ` Fabio Estevam
2015-05-21 16:17 ` Stefano Babic
2015-05-21 16:46 ` Stefan Roese
2015-05-21 17:06 ` Stefano Babic
2015-05-21 17:07 ` Tim Harvey
2015-05-15 14:25 ` [U-Boot] [PATCH 00/19] imx: ventana: misc updates Stefano Babic
2015-05-15 16:30 ` Tim Harvey
2015-05-15 16:56 ` Stefano Babic
2015-05-15 18:57 ` Otavio Salvador
2015-05-21 16:56 ` Tom Rini
2015-05-21 17:02 ` Stefano Babic
2015-05-15 16:14 ` [U-Boot] [PATCH v2 08/19] imx: ventana: config: use MMC SPL RAW support Tim Harvey
2015-05-19 13:06 ` Stefano Babic
2015-05-15 16:17 ` [U-Boot] [PATCH v2 09/19] imx: ventana: (cosmetic) clean up size defines for improved readability Tim Harvey
2015-05-19 13:06 ` Stefano Babic
2015-05-15 16:18 ` [U-Boot] [PATCH v2 17/19] imx: ventana: add pmic_setup to SPL Tim Harvey
2015-05-19 13:07 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5556009C.80707@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox