public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: i2c: Add compatibility functions for dm_i2c_reg_read/write()
Date: Mon, 18 May 2015 08:03:12 +0200	[thread overview]
Message-ID: <555980A0.5060908@denx.de> (raw)
In-Reply-To: <1431810101-5315-1-git-send-email-sjg@chromium.org>

Hello Simon,

Am 16.05.2015 23:01, schrieb Simon Glass:
> Add the legacy i2c_reg_read/write() functions to the compatibility layer
> so that they can be used when CONFIG_DM_I2C_COMPAT is defined.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   drivers/i2c/i2c-uclass-compat.c | 21 +++++++++++++++++++++
>   include/i2c.h                   |  6 ++++++
>   2 files changed, 27 insertions(+)

Acked-by: Heiko Schocher <hs@denx.de>

Thanks!

bye,
Heiko

>
> diff --git a/drivers/i2c/i2c-uclass-compat.c b/drivers/i2c/i2c-uclass-compat.c
> index 223f238..5606d1f 100644
> --- a/drivers/i2c/i2c-uclass-compat.c
> +++ b/drivers/i2c/i2c-uclass-compat.c
> @@ -106,3 +106,24 @@ void board_i2c_init(const void *blob)
>   {
>   	/* Nothing to do here - the init happens through driver model */
>   }
> +
> +uint8_t i2c_reg_read(uint8_t chip_addr, uint8_t offset)
> +{
> +	struct udevice *dev;
> +	int ret;
> +
> +	ret = i2c_compat_get_device(chip_addr, 1, &dev);
> +	if (ret)
> +		return 0xff;
> +	return dm_i2c_reg_read(dev, offset);
> +}
> +
> +void i2c_reg_write(uint8_t chip_addr, uint8_t offset, uint8_t val)
> +{
> +	struct udevice *dev;
> +	int ret;
> +
> +	ret = i2c_compat_get_device(chip_addr, 1, &dev);
> +	if (!ret)
> +		dm_i2c_reg_write(dev, offset, val);
> +}
> diff --git a/include/i2c.h b/include/i2c.h
> index ddfebc4..9300d97 100644
> --- a/include/i2c.h
> +++ b/include/i2c.h
> @@ -284,6 +284,12 @@ void i2c_init(int speed, int slaveaddr);
>    */
>   void board_i2c_init(const void *blob);
>
> +/*
> + * Compatibility functions for driver model.
> + */
> +uint8_t i2c_reg_read(uint8_t addr, uint8_t reg);
> +void i2c_reg_write(uint8_t addr, uint8_t reg, uint8_t val);
> +
>   #endif
>
>   /*
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2015-05-18  6:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-16 21:01 [U-Boot] [PATCH] dm: i2c: Add compatibility functions for dm_i2c_reg_read/write() Simon Glass
2015-05-18  6:03 ` Heiko Schocher [this message]
2015-06-11 20:18   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555980A0.5060908@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox