public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/4] arm: ls102xa: Enable Driver Model SPI for ls1021aqds
Date: Mon, 18 May 2015 09:22:43 -0700	[thread overview]
Message-ID: <555A11D3.5070704@freescale.com> (raw)
In-Reply-To: <1431955488-10937-1-git-send-email-haikun.wang@freescale.com>

Haikun,

On 05/18/2015 06:24 AM, Haikun Wang wrote:
> Enable Driver Model SPI for ls1021aqds board.
> DSPI and QSPI is enabled only when boot from QSPI.
> DSPI and QSPI are compatible under Driver Model SPI.
> 
> Signed-off-by: Haikun Wang <Haikun.Wang@freescale.com>
> ---
> Changes in v3:
> - Remove CONFIG_SPI_FLASH_ATMEL
> - IS_ENABLED(CONFIG_XXX) is only work with configure option in Kconfig,
>   and DM core code use IS_ENABLED(), so configure option in head file
>   can't work, so remove CONFIG_OF_CONTROL CONFIG_OF_SEPARATE CONFIG_DM CONFIG_DM_SPI
> 
> Changes in v2:
> - Move all changes inside of CONFIG_QSPI_BOOT 
> 
> Changes in v1: None
>  include/configs/ls1021aqds.h | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)


I lost track of your patch set. You have v3 3/4 and v3 4/4. Where are the first
two patches in this set?

The subject arm:ls102xa is not too bad. For future patches, I prefer the subject
to be <arch>/<soc>, or <arch>/<board>. This one should have arm/ls1021aqds, or
armv7/ls1021aqds. It helps maintainers to delegate the patches to custodians.

York

  reply	other threads:[~2015-05-18 16:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 13:24 [U-Boot] [PATCH v3 3/4] arm: ls102xa: Enable Driver Model SPI for ls1021aqds Haikun Wang
2015-05-18 16:22 ` York Sun [this message]
2015-05-19  2:50   ` Wang Haikun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555A11D3.5070704@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox