From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used
Date: Tue, 19 May 2015 10:57:48 +0200 [thread overview]
Message-ID: <555AFB0C.5050301@denx.de> (raw)
In-Reply-To: <5559FAB9.4090103@boundarydevices.com>
Hi Prabhakar, Eric,
On 18/05/2015 16:44, Eric Nelson wrote:
> Hi Prabhakar,
>
> On 05/18/2015 04:43 AM, Prabhakar Kushwaha wrote:
>> Fix below warning
>> arch/arm/imx-common/cpu.c:29:14: warning: ?get_reset_cause? defined but
>> not used
>> static char *get_reset_cause(void)
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> ---
>> arch/arm/imx-common/cpu.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c
>> index 067d08f..0cd08cb 100644
>> --- a/arch/arm/imx-common/cpu.c
>> +++ b/arch/arm/imx-common/cpu.c
>> @@ -24,6 +24,7 @@
>> #include <fsl_esdhc.h>
>> #endif
>>
>> +#if defined(CONFIG_DISPLAY_CPUINFO)
>> static u32 reset_cause = -1;
>>
>> static char *get_reset_cause(void)
>> @@ -60,6 +61,7 @@ u32 get_imx_reset_cause(void)
>> {
>> return reset_cause;
>> }
>> +#endif
>>
>> #if defined(CONFIG_MX53) || defined(CONFIG_MX6)
>> #if defined(CONFIG_MX53)
>>
>
> This makes the dependency clear, even if it's odd.
>
> Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
Yes, anyway this is what we already use for other SOCs (iMX31, iMX35,..
they have a local get_reset_cause() protected by this switch).
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2015-05-19 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 11:43 [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used Prabhakar Kushwaha
2015-05-18 14:44 ` Eric Nelson
2015-05-19 8:57 ` Stefano Babic [this message]
2015-05-19 13:21 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555AFB0C.5050301@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox