From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Tue, 19 May 2015 10:57:48 +0200
Subject: [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause'
 defined but not used
In-Reply-To: <5559FAB9.4090103@boundarydevices.com>
References: <1431949432-25248-1-git-send-email-prabhakar@freescale.com>
 <5559FAB9.4090103@boundarydevices.com>
Message-ID: <555AFB0C.5050301@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Prabhakar, Eric,

On 18/05/2015 16:44, Eric Nelson wrote:
> Hi Prabhakar,
> 
> On 05/18/2015 04:43 AM, Prabhakar Kushwaha wrote:
>> Fix below warning
>> arch/arm/imx-common/cpu.c:29:14: warning: ?get_reset_cause? defined but
>> not used
>>  static char *get_reset_cause(void)
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> ---
>>  arch/arm/imx-common/cpu.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c
>> index 067d08f..0cd08cb 100644
>> --- a/arch/arm/imx-common/cpu.c
>> +++ b/arch/arm/imx-common/cpu.c
>> @@ -24,6 +24,7 @@
>>  #include <fsl_esdhc.h>
>>  #endif
>>  
>> +#if defined(CONFIG_DISPLAY_CPUINFO)
>>  static u32 reset_cause = -1;
>>  
>>  static char *get_reset_cause(void)
>> @@ -60,6 +61,7 @@ u32 get_imx_reset_cause(void)
>>  {
>>  	return reset_cause;
>>  }
>> +#endif
>>  
>>  #if defined(CONFIG_MX53) || defined(CONFIG_MX6)
>>  #if defined(CONFIG_MX53)
>>
> 
> This makes the dependency clear, even if it's odd.
> 
> Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com>
> 

Yes, anyway this is what we already use for other SOCs (iMX31, iMX35,..
they have a local get_reset_cause() protected by this switch).

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================