From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env_nand: use nand_spl_load_image for readenv if SPL
Date: Tue, 19 May 2015 15:02:52 +0200 [thread overview]
Message-ID: <555B347C.6040700@denx.de> (raw)
In-Reply-To: <1431716372.3868.208.camel@freescale.com>
Hi Tim,
On 15/05/2015 20:59, Scott Wood wrote:
> On Thu, 2015-05-14 at 11:48 -0700, Tim Harvey wrote:
>> The readenv() implementation of env_nand uses the mtd layer which is
>> unnecessary overhead in SPL when we already have a nand_spl_load_image()
>> function that doesn't need it. Using this instead eliminates the need
>> to provide a mtd_read for SPL env as well as reduces code (4KB savings in IMX6
>> SPL).
>>
>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>> ---
>> common/env_nand.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>
> Acked-by: Scott Wood <scottwood@freescale.com>
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2015-05-19 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 18:48 [U-Boot] [PATCH] env_nand: use nand_spl_load_image for readenv if SPL Tim Harvey
2015-05-15 18:59 ` Scott Wood
2015-05-19 13:02 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555B347C.6040700@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox