From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Fri, 22 May 2015 09:30:46 +0200 Subject: [U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory In-Reply-To: <1432234950.5748.131.camel@hellion.org.uk> References: <1432216765-8421-1-git-send-email-r.spliet@ultimaker.com> <1432216765-8421-3-git-send-email-r.spliet@ultimaker.com> <555E2665.6060202@redhat.com> <1432234950.5748.131.camel@hellion.org.uk> Message-ID: <555EDB26.9060005@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 21-05-15 21:02, Ian Campbell wrote: > On Thu, 2015-05-21 at 20:39 +0200, Hans de Goede wrote: > [...] >> Please create a struct reflecting the register layout and >> then initialize a ptr to this struct from the base-address >> and get register addresses this way, this is how we deal >> with this in pretty much all other sunxi code, see e.g.: > > This isn't just sunxi, I believe it is u-boot's preferred way to do > things generally. > [...] >> Otherwise this looks like a good start, with the coding >> style issues fixed I would not be opposed against merging >> this as a first step to growing proper nand support. >> >> Ian, is that ok with you ? > > You mean with the coding style fixed but not (necessarily) all the other > issues you pointed out (timeouts on loops, structs for register > accesses)? Sorry, what I meant is are you ok with starting with merging just the SPL support without having support for actually reading the kernel, etc. as a first step. The SPL support would have to have all the issues (*) I pointed out fixed before merging. Regards, Hans *) Except for those where I explicitly said they can be fixed up with a follow up commit.