From: Soeren Moch <smoch@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 08/10] imx6: standardise filesystem and boot options
Date: Sat, 23 May 2015 06:35:24 +0200 [thread overview]
Message-ID: <5560038C.4070901@web.de> (raw)
In-Reply-To: <CALeDE9M1pv6Fb3Yiop7gFXEhr78ciFFdK+i6qBkkdZ0JGO4bWw@mail.gmail.com>
On 23.05.2015 01:06, Peter Robinson wrote:
>
> On 22 May 2015 19:48, "Soeren Moch" <smoch at web.de <mailto:smoch@web.de>>
> wrote:
>>>
>>> Move all standard filesystem, partition and fdt options to mx6_common.
>>>
>>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com
> <http://gmail.com> <http://lists.denx.de/mailman/listinfo/u-boot>>
>>
>>
>> [...]
>>
>>
>>> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
>>> index 07fc3e8..c323038 100644
>>> --- a/include/configs/mx6_common.h
>>> +++ b/include/configs/mx6_common.h
>>> @@ -67,6 +67,17 @@
>>> #define CONFIG_CONS_INDEX 1
>>> #define CONFIG_BAUDRATE 115200
>>>
>>> +/* Filesystems and image support */
>>> +#define CONFIG_OF_LIBFDT
>>> +#define CONFIG_CMD_BOOTZ
>>> +#define CONFIG_SUPPORT_RAW_INITRD
>>> +#define CONFIG_CMD_FS_GENERIC
>>> +#define CONFIG_DOS_PARTITION
>>> +#define CONFIG_CMD_EXT2
>>> +#define CONFIG_CMD_EXT4
>>> +#define CONFIG_CMD_EXT4_WRITE
>>> +#define CONFIG_CMD_FAT
>>> +
>>> /* Miscellaneous configurable options */
>>> #define CONFIG_SYS_NO_FLASH
>>> #undef CONFIG_CMD_IMLS
>>
>>
>>
>> Peter,
>>
>> Thanks for fixing EFI_PARTITION in tbs2910.
>>
>> You still define CONFIG_CMD_EXT2 and CONFIG_CMD_EXT4, while
>> only CONFIG_CMD_EXT4 is required. That is not really a problem,
>> but since you are doing cleanup here...
>>
>
> Yes, i looked at this and a good half were including ext2. I plan on
> doing another pass so I figure there's enough churn already in this
> series so get it merged and ensure there's no regression and then
> re-review.
>
Ah ok, if you want to run ext2ls / ext2load you need CONFIG_CMD_EXT2
explicitly. I thought that this would also be enabled by CONFIG_CMD_EXT4
automatically.
Sorry for the noise,
Soeren
next prev parent reply other threads:[~2015-05-23 4:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 16:30 [U-Boot] [PATCH 0/10 v3] i.MX6: move duplicated options to mx6_common to standardise mx6 config Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 01/10] novena: standardise mx6_common.h include Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 02/10] imx6: move all standard includes to mx6_common.h Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 03/10] imx6: move generic imx6 options " Peter Robinson
2015-05-22 18:18 ` Soeren Moch
2015-05-26 11:39 ` Stefano Babic
2015-05-26 12:10 ` Soeren Moch
2015-05-29 18:02 ` Soeren Moch
2015-05-22 16:30 ` [U-Boot] [PATCH 04/10] imx6: move standard ATAG configs " Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define " Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 06/10] imx6: centralise common boot options in mx6_common.h Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 07/10] imx6: move generic miscellaneous and overwrite options Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 08/10] imx6: standardise filesystem and boot options Peter Robinson
2015-05-22 18:48 ` Soeren Moch
2015-05-22 23:06 ` Peter Robinson
2015-05-23 4:35 ` Soeren Moch [this message]
2015-05-22 16:30 ` [U-Boot] [PATCH 09/10] imx6: generic MMC config options to mx6_common Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 10/10] mx6: standardise CONFIG_CMD_CACHE Peter Robinson
2015-05-26 12:11 ` [U-Boot] [PATCH 0/10 v3] i.MX6: move duplicated options to mx6_common to standardise mx6 config Stefano Babic
2015-05-26 13:23 ` Peter Robinson
2015-05-26 14:06 ` Stefano Babic
2015-05-27 1:45 ` Fabio Estevam
2015-05-27 2:08 ` Fabio Estevam
2015-05-27 6:26 ` Stefano Babic
-- strict thread matches above, loose matches on Subject: below --
2015-05-11 16:22 [U-Boot] [PATCH 0/10 v2] " Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 08/10] imx6: standardise filesystem and boot options Peter Robinson
2015-05-11 17:21 ` Soeren Moch
2015-05-11 17:55 ` Soeren Moch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5560038C.4070901@web.de \
--to=smoch@web.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox