From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Date: Sat, 23 May 2015 06:35:24 +0200 Subject: [U-Boot] [PATCH 08/10] imx6: standardise filesystem and boot options In-Reply-To: References: <1432312253-18040-9-git-send-email-pbrobinson@gmail.com> <555F7A00.2000803@web.de> Message-ID: <5560038C.4070901@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 23.05.2015 01:06, Peter Robinson wrote: > > On 22 May 2015 19:48, "Soeren Moch" > > wrote: >>> >>> Move all standard filesystem, partition and fdt options to mx6_common. >>> >>> Signed-off-by: Peter Robinson > >> >> >> [...] >> >> >>> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h >>> index 07fc3e8..c323038 100644 >>> --- a/include/configs/mx6_common.h >>> +++ b/include/configs/mx6_common.h >>> @@ -67,6 +67,17 @@ >>> #define CONFIG_CONS_INDEX 1 >>> #define CONFIG_BAUDRATE 115200 >>> >>> +/* Filesystems and image support */ >>> +#define CONFIG_OF_LIBFDT >>> +#define CONFIG_CMD_BOOTZ >>> +#define CONFIG_SUPPORT_RAW_INITRD >>> +#define CONFIG_CMD_FS_GENERIC >>> +#define CONFIG_DOS_PARTITION >>> +#define CONFIG_CMD_EXT2 >>> +#define CONFIG_CMD_EXT4 >>> +#define CONFIG_CMD_EXT4_WRITE >>> +#define CONFIG_CMD_FAT >>> + >>> /* Miscellaneous configurable options */ >>> #define CONFIG_SYS_NO_FLASH >>> #undef CONFIG_CMD_IMLS >> >> >> >> Peter, >> >> Thanks for fixing EFI_PARTITION in tbs2910. >> >> You still define CONFIG_CMD_EXT2 and CONFIG_CMD_EXT4, while >> only CONFIG_CMD_EXT4 is required. That is not really a problem, >> but since you are doing cleanup here... >> > > Yes, i looked at this and a good half were including ext2. I plan on > doing another pass so I figure there's enough churn already in this > series so get it merged and ensure there's no regression and then > re-review. > Ah ok, if you want to run ext2ls / ext2load you need CONFIG_CMD_EXT2 explicitly. I thought that this would also be enabled by CONFIG_CMD_EXT4 automatically. Sorry for the noise, Soeren