public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] wandboard: Add board revision detection support
Date: Sat, 23 May 2015 18:27:54 +0200	[thread overview]
Message-ID: <5560AA8A.8010601@ahsoftware.de> (raw)
In-Reply-To: <87siaob018.fsf@aikidev.net>

Am 23.05.2015 um 02:38 schrieb Vagrant Cascadian:
> On 2015-05-21, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> There are two revisions of wandboard: version B1 and C1.
>>
>> Add the revision detection support, so that the correct dtb file can
>> be automatically loaded.
>>
>> Based on the patch from Richard Hu <hakahu@gmail.com>.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Tested on a Wandboard dual (rev c1) and wandboard quad (rev b1).
>
> Tested-By: Vagrant Cascadian <vagrant@aikidev.net>
>
>> ---
>> Changes since v1:
>>
>> - Fixed commit log to 'automatically loaded'.
>>
>>   board/wandboard/wandboard.c | 26 +++++++++++++++++++++++++-
>>   include/configs/wandboard.h |  8 ++++++--

Wouldn't it be better to just enable CONFIG_CMD_GPIO and then change the 
boot-script in the config to something like "if gpio ..." instead of 
adding something special?

Assuming the gpio command works on imx, which I haven't tested or looked up.

Regards,

Alexander Holler

  reply	other threads:[~2015-05-23 16:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 22:24 [U-Boot] [PATCH v2] wandboard: Add board revision detection support Fabio Estevam
2015-05-22  7:49 ` Stefano Babic
2015-05-23  0:38 ` Vagrant Cascadian
2015-05-23 16:27   ` Alexander Holler [this message]
2015-05-24  7:43     ` Stefano Babic
2015-05-24 14:27       ` Fabio Estevam
2015-05-24 14:30         ` Stefano Babic
2015-05-24 17:29         ` Alexander Holler
2015-05-24 18:03           ` Alexander Holler
2015-05-24 18:47             ` Fabio Estevam
2015-05-24 22:22               ` Alexander Holler
2015-05-24 23:42                 ` Fabio Estevam
2015-05-25  9:41                   ` Wolfgang Denk
2015-05-25 11:25                     ` Fabio Estevam
2015-05-26 18:55                     ` Alexander Holler
2015-05-26 22:11                       ` Fabio Estevam
2015-05-24 19:03             ` Tom Rini
2015-05-24 18:44           ` Fabio Estevam
2015-06-08  6:35 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5560AA8A.8010601@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox